[jira] [Work logged] (HIVE-25938) Print excluded rules from CBO

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25938?focusedWorklogId=723850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723850 ]

ASF GitHub Bot logged work on HIVE-25938:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 17:41
            Start Date: 09/Feb/22 17:41
    Worklog Time Spent: 10m 
      Work Description: asolimando opened a new pull request #3011:
URL: https://github.com/apache/hive/pull/3011


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   Add DEBUG logs showing the rule description regex applied for filtering CBO rules from planning. Prints the same information for EXPLAIN [FORMATTED] [CBO], since excluded rules can have a heavy impact on planning.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Investigation can be much harder if some rules are excluded via config and this info is not in the logs/explain statements.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   The output format of the EXPLAIN commands changed, text format should not be parsed so it won't make a difference, in the JSON format, for EXPLAIN FORMATTED CBO there is an extra "cboInfo" tag like for "EXPLAIN FORMATTED" now.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   `mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile="excluded_rule_explain.q" -Dtest.output.overwrite -pl itests/qtest -Pitests`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 723850)
    Remaining Estimate: 0h
            Time Spent: 10m

> Print excluded rules from CBO
> -----------------------------
>
>                 Key: HIVE-25938
>                 URL: https://issues.apache.org/jira/browse/HIVE-25938
>             Project: Hive
>          Issue Type: Improvement
>          Components: CBO
>    Affects Versions: 4.0.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HIVE-25880 introduced a configuration parameter for excluding CBO rules based on a regex on their description.
> Calcite logs when a rule is excluded (see [AbstractRelOptPlanner.java#L316|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java#L316] and [VolcanoRuleCall.java#L169|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java#L169]).
> To ease investigations, this should be complemented by printing the regex used (if not blank) in Hive DEBUG logs, and the same in CBO information (i.e., EXPLAIN CBO's output).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)