You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/06 04:08:30 UTC
[GitHub] [incubator-echarts] yanheSu opened a new pull request #12761: fix(legend):when scroll legend has enough height, rich text config wi…
yanheSu opened a new pull request #12761:
URL: https://github.com/apache/incubator-echarts/pull/12761
…ll not work, fix#12753
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Regardless of whether the scroll legend controller exists, the width limit (`setClipPath`) of the text node should be effective
### Fixed issues
<!--
- #xxxx: ...
-->
- #12753
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
rich text config(width) in scroll legend will not work, when scroll legend has enough height.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
<img width="688" alt="图片" src="https://user-images.githubusercontent.com/47936701/83935427-197d8b80-a7ec-11ea-9c10-de9bb9201c23.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
legend-scroll-width-limit.html
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12761: fix(legend):when scroll legend has enough height, rich text config wi…
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12761:
URL: https://github.com/apache/incubator-echarts/pull/12761#issuecomment-668636562
@yanheSu Do you mind providing test cases? I see legend-scroll-width-limit.html in your description. But it seems not exists in the changed files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12761: fix(legend):when scroll legend has enough height, rich text config wi…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12761:
URL: https://github.com/apache/incubator-echarts/pull/12761#issuecomment-639975999
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] yanheSu commented on pull request #12761: fix(legend):when scroll legend has enough height, rich text config wi…
Posted by GitBox <gi...@apache.org>.
yanheSu commented on pull request #12761:
URL: https://github.com/apache/incubator-echarts/pull/12761#issuecomment-671159389
@pissang test case has been added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12761: fix(legend):when scroll legend has enough height, rich text config wi…
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #12761:
URL: https://github.com/apache/incubator-echarts/pull/12761#issuecomment-668636562
@yanheSu Do you mind providing test cases? I notice legend-scroll-width-limit.html in your description. But it seems not exists in the changed files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org