You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/05 14:38:17 UTC

(commons-compress) branch master updated: Make private class final

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 4026992a Make private class final
4026992a is described below

commit 4026992a6abc202587a3b2ac25d8b8b9dc5f5136
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 09:38:09 2023 -0500

    Make private class final
---
 .../apache/commons/compress/archivers/sevenz/SevenZOutputFile.java    | 2 +-
 .../apache/commons/compress/archivers/zip/ZipArchiveInputStream.java  | 2 +-
 .../apache/commons/compress/compressors/deflate64/HuffmanDecoder.java | 4 ++--
 .../commons/compress/harmony/pack200/tests/NewAttributeBandsTest.java | 2 +-
 .../compress/harmony/unpack200/tests/NewAttributeBandsTest.java       | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZOutputFile.java b/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZOutputFile.java
index 9dc622f1..0e3a7c26 100644
--- a/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZOutputFile.java
+++ b/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZOutputFile.java
@@ -62,7 +62,7 @@ import org.apache.commons.compress.utils.TimeUtils;
  */
 public class SevenZOutputFile implements Closeable {
 
-    private class OutputStreamWrapper extends OutputStream {
+    private final class OutputStreamWrapper extends OutputStream {
 
         private static final int BUF_SIZE = 8192;
         private final ByteBuffer buffer = ByteBuffer.allocate(BUF_SIZE);
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
index b6797a0d..dafa78b7 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
@@ -85,7 +85,7 @@ public class ZipArchiveInputStream extends ArchiveInputStream<ZipArchiveEntry> i
     /**
      * Bounded input stream adapted from commons-io
      */
-    private class BoundedInputStream extends FilterInputStream {
+    private final class BoundedInputStream extends FilterInputStream {
 
         /** the max length to provide */
         private final long max;
diff --git a/src/main/java/org/apache/commons/compress/compressors/deflate64/HuffmanDecoder.java b/src/main/java/org/apache/commons/compress/compressors/deflate64/HuffmanDecoder.java
index 9aad879d..90f0328a 100644
--- a/src/main/java/org/apache/commons/compress/compressors/deflate64/HuffmanDecoder.java
+++ b/src/main/java/org/apache/commons/compress/compressors/deflate64/HuffmanDecoder.java
@@ -127,7 +127,7 @@ class HuffmanDecoder implements Closeable {
         }
     }
 
-    private class HuffmanCodes extends DecoderState {
+    private final class HuffmanCodes extends DecoderState {
         private boolean endOfBlock;
         private final HuffmanState state;
         private final BinaryTreeNode lengthTree;
@@ -242,7 +242,7 @@ class HuffmanDecoder implements Closeable {
         }
     }
 
-    private class UncompressedState extends DecoderState {
+    private final class UncompressedState extends DecoderState {
         private final long blockLength;
         private long read;
 
diff --git a/src/test/java/org/apache/commons/compress/harmony/pack200/tests/NewAttributeBandsTest.java b/src/test/java/org/apache/commons/compress/harmony/pack200/tests/NewAttributeBandsTest.java
index 47a1a3b6..d11e6a0e 100644
--- a/src/test/java/org/apache/commons/compress/harmony/pack200/tests/NewAttributeBandsTest.java
+++ b/src/test/java/org/apache/commons/compress/harmony/pack200/tests/NewAttributeBandsTest.java
@@ -52,7 +52,7 @@ import org.junit.jupiter.params.provider.ValueSource;
  */
 public class NewAttributeBandsTest {
 
-    private class MockNewAttributeBands extends NewAttributeBands {
+    private final class MockNewAttributeBands extends NewAttributeBands {
 
         public MockNewAttributeBands(final int effort, final CpBands cpBands,
                 final SegmentHeader header, final AttributeDefinition def)
diff --git a/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/NewAttributeBandsTest.java b/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/NewAttributeBandsTest.java
index 26a506d2..ceac84cf 100644
--- a/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/NewAttributeBandsTest.java
+++ b/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/NewAttributeBandsTest.java
@@ -43,7 +43,7 @@ import org.junit.jupiter.params.provider.ValueSource;
  */
 public class NewAttributeBandsTest extends AbstractBandsTest {
 
-    private class MockNewAttributeBands extends NewAttributeBands {
+    private final class MockNewAttributeBands extends NewAttributeBands {
 
         public MockNewAttributeBands(final Segment segment, final AttributeLayout layout)
                 throws IOException {