You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/20 08:09:22 UTC

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18426


Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................

[unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
is not steady and proability fail,

I will try to fix it, by confirm reaching size_limit and not reach row_limit.

Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 9 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18426/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................

[unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
is not steady and proability fail. Errors at Jenkins like this:

Error Message
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK
Stacktrace
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK

I will try to fix the case, by confirm reaching size_limit and not reach row_limit.

Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Reviewed-on: http://gerrit.cloudera.org:8080/18426
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@429
PS1, Line 429:   ASSERT_OK(SetupClient(kUser));
Could you explain why it failed when row_limit is kRowCountLimit?



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 15:27:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18426

to look at the new patch set (#3).

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................

[unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
is not steady and proability fail. Errors at Jenkins like this:

Error Message
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK
Stacktrace
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK

I will try to fix the case, by confirm reaching size_limit and not reach row_limit.

Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18426/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 15:21:26 +0000
Gerrit-HasComments: No

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Removed Code-Review+2 by Yingchun Lai <ac...@gmail.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@216
PS1, Line 216:   void TestSizeLimit(int64_t row_count_limit = kRowCountLimit) {
> Typo? You can define it as static variable, then build will success.
Sorry, a mistake.  DONE



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 02:29:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18426

to look at the new patch set (#4).

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................

[unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
is not steady and proability fail. Errors at Jenkins like this:

Error Message
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK
Stacktrace
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK

I will try to fix the case, by confirm reaching size_limit and not reach row_limit.

Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18426/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG@9
PS1, Line 9: DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
Better to paste what error you got, and what's the idea to fix it.


http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@216
PS1, Line 216:   void TestSizeLimit(int64_t row_count_limit = -1) {
How about void TestSizeLimit(int64_t row_count_limit = kRowCountLimit) ?



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sun, 24 Apr 2022 06:47:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 15:27:20 +0000
Gerrit-HasComments: No

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18426/1//COMMIT_MSG@9
PS1, Line 9: DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
> Better to paste what error you got, and what's the idea to fix it.
Done


http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@216
PS1, Line 216:   void TestSizeLimit(int64_t row_count_limit = -1) {
> How about void TestSizeLimit(int64_t row_count_limit = kRowCountLimit) ?
Compile failed, static variable cann't be used like this.



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 10:13:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5:

> Patch Set 5: Code-Review+2
> 
> (1 comment)
> 
> Thank you for the fix!

Thanks, I got it.


-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Apr 2022 02:35:03 +0000
Gerrit-HasComments: No

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

Thank you for the fix!

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@429
PS1, Line 429:   ASSERT_OK(SetupClient(kUser));
> Could you explain why it failed when row_limit is kRowCountLimit?
As I understand, the issue was two fold:
  1) failure to hit the disk space limit because of compactions and GC going on right after inserting the rows
  2) failure to stop hitting the disk space limit because some data hasn't been compacted yet

After the update with patch https://github.com/apache/kudu/commit/c146454dfa6a840b79a33f16bc2df6a3b6c93600 , only the first issue left as I can see:

src/kudu/integration-tests/write_limit-itest.cc:429: Failure
Expected: TestSizeLimit() doesn't generate new fatal failures in the current thread.
  Actual: it does.  

With more rows inserted, the compaction, GC, and other jazz isn't able to shrink the amount of data fast enough even in case of some scheduling anomalies.



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 19:22:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc
File src/kudu/integration-tests/write_limit-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@216
PS1, Line 216:   void TestSizeLimit(int64_t row_count_limit = -1) {
> Compile failed, static variable cann't be used like this.
Typo? You can define it as static variable, then build will success.



-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 10:11:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18426

to look at the new patch set (#2).

Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
......................................................................

[unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota

DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
is not steady and proability fail. Errors at Jenkins like this:

Error Message
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK
Stacktrace
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/write_limit-itest.cc:229
Value of: s.IsIOError()
      Actual: false
      Expected: true
      OK

I will try to fix the case, by confirm reaching size_limit and not reach row_limit.

Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
---
M src/kudu/integration-tests/write_limit-itest.cc
1 file changed, 9 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/18426/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>