[GitHub] [kvrocks] caipengbo commented on a diff in pull request #1664: Small fix mismatching defaults options value and his comments

["caipengbo (via GitHub)" <gi...@apache.org>]

caipengbo commented on code in PR #1664:
URL: https://github.com/apache/kvrocks/pull/1664#discussion_r1290791595


##########
kvrocks.conf:
##########
@@ -576,7 +576,7 @@ rocksdb.target_file_size_base 128
 # The default and the minimum number is 2, so that when 1 write buffer
 # is being flushed to storage, new writes can continue to the other
 # write buffer.
-# If max_write_buffer_number > 3, writing will be slowed down to
+# If max_write_buffer_number < 3, writing will be slowed down to

Review Comment:
   This is greater than 3, please refer to:
   https://github.com/facebook/rocksdb/blob/36f48d16a8a14fb3bb22c6d9ed5ba4ad1f01bc50/include/rocksdb/advanced_options.h#L282



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org