You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2015/07/02 03:49:19 UTC
[14/25] hive git commit: HIVE-10794: Remove the dependence from
ErrorMsg to HiveUtils (Owen O'Malley via Prasanth Jayachandran)
HIVE-10794: Remove the dependence from ErrorMsg to HiveUtils (Owen O'Malley via Prasanth Jayachandran)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/f755652f
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/f755652f
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/f755652f
Branch: refs/heads/llap
Commit: f755652ff053c57373a4c072d4c93cf9b7169e01
Parents: 052643c
Author: Prasanth Jayachandran <j....@gmail.com>
Authored: Wed Jul 1 10:00:08 2015 -0700
Committer: Prasanth Jayachandran <j....@gmail.com>
Committed: Wed Jul 1 10:00:08 2015 -0700
----------------------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java | 6 ++++--
.../java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java | 8 --------
2 files changed, 4 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/f755652f/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java b/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
index 20509ce..f012b72 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
@@ -665,6 +665,8 @@ public enum ErrorMsg {
return sb.toString();
}
+ static final String LINE_SEP = System.getProperty("line.separator");
+
public static void renderOrigin(StringBuilder sb, ASTNodeOrigin origin) {
while (origin != null) {
sb.append(" in definition of ");
@@ -672,9 +674,9 @@ public enum ErrorMsg {
sb.append(" ");
sb.append(origin.getObjectName());
sb.append(" [");
- sb.append(HiveUtils.LINE_SEP);
+ sb.append(LINE_SEP);
sb.append(origin.getObjectDefinition());
- sb.append(HiveUtils.LINE_SEP);
+ sb.append(LINE_SEP);
sb.append("] used as ");
sb.append(origin.getUsageAlias());
sb.append(" at ");
http://git-wip-us.apache.org/repos/asf/hive/blob/f755652f/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
index c4633f6..719728d 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
@@ -45,14 +45,6 @@ import org.apache.hadoop.util.ReflectionUtils;
*/
public final class HiveUtils {
- public static final char QUOTE = '"';
- public static final char COLON = ':';
- public static final String LBRACKET = "[";
- public static final String RBRACKET = "]";
- public static final String LBRACE = "{";
- public static final String RBRACE = "}";
- public static final String LINE_SEP = System.getProperty("line.separator");
-
public static String escapeString(String str) {
int length = str.length();
StringBuilder escape = new StringBuilder(length + 16);