You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by mm...@apache.org on 2014/08/15 22:02:11 UTC
[1/2] git commit: Add missing test, skip some specs on wp
Repository: cordova-plugin-contacts
Updated Branches:
refs/heads/master d5c112643 -> 79c7a1baa
Add missing test, skip some specs on wp
Added in a few things that were added to mobile-spec after tests were
initially ported:
-new find method spec
-specs which require manual user confirmation on wp are skipped
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/ceed0b78
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/ceed0b78
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/ceed0b78
Branch: refs/heads/master
Commit: ceed0b783aa0179bfdafe7003e481f493cd4ec84
Parents: d5c1126
Author: Staci Cooper <sm...@us.ibm.com>
Authored: Thu Aug 14 15:51:59 2014 -0400
Committer: Staci Cooper <sm...@us.ibm.com>
Committed: Thu Aug 14 15:51:59 2014 -0400
----------------------------------------------------------------------
tests/tests.js | 39 +++++++++++++++++++++++++++++++++------
1 file changed, 33 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/ceed0b78/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index 2bdae2a..2e0b44a 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -22,8 +22,9 @@
exports.defineAutoTests = function () {
// global to store a contact so it doesn't have to be created or retrieved multiple times
// all of the setup/teardown test methods can reference the following variables to make sure to do the right cleanup
- var gContactObj = null;
- var gContactId = null;
+ var gContactObj = null,
+ gContactId = null,
+ isWindowsPhone = cordova.platformId == 'windowsphone';
var fail = function(done) {
expect(true).toBe(false);
@@ -61,6 +62,16 @@ exports.defineAutoTests = function () {
obj.multiple=true;
navigator.contacts.find(["displayName", "name", "phoneNumbers", "emails"], win, fail.bind(null, done), obj);
});
+ it("success callback should be called with an array, even if partial ContactFindOptions specified", function (done) {
+ var win = function (result) {
+ expect(result).toBeDefined();
+ expect(result instanceof Array).toBe(true);
+ done();
+ };
+
+ navigator.contacts.find(["displayName", "name", "phoneNumbers", "emails"], win, fail.bind(null, done),
+ { multiple: true });
+ });
it("contacts.spec.4 should throw an exception if success callback is empty", function() {
var obj = new ContactFindOptions();
obj.filter="";
@@ -87,7 +98,11 @@ exports.defineAutoTests = function () {
afterEach(removeContact);
- it("contacts.spec.6 should be able to find a contact by name", function(done) {
+ it("contacts.spec.6 should be able to find a contact by name", function (done) {
+ if (isWindowsPhone) {
+ done();
+ return;
+ }
var foundName = function(result) {
var bFound = false;
try {
@@ -259,7 +274,11 @@ exports.defineAutoTests = function () {
});
});
describe('save method', function () {
- it("contacts.spec.20 should be able to save a contact", function(done) {
+ it("contacts.spec.20 should be able to save a contact", function (done) {
+ if (isWindowsPhone) {
+ done();
+ return;
+ }
var bDay = new Date(1976, 6,4);
gContactObj = navigator.contacts.create({"gender": "male", "note": "my note", "name": {"familyName": "Delete", "givenName": "Test"}, "emails": [{"value": "here@there.com"}, {"value": "there@here.com"}], "birthday": bDay});
@@ -282,7 +301,11 @@ exports.defineAutoTests = function () {
gContactObj.save(saveSuccess, saveFail);
});
// HACK: there is a reliance between the previous and next test. This is bad form.
- it("contacts.spec.21 update a contact", function(done) {
+ it("contacts.spec.21 update a contact", function (done) {
+ if (isWindowsPhone) {
+ done();
+ return;
+ }
expect(gContactObj).toBeDefined();
var bDay = new Date(1975, 5,4);
@@ -337,7 +360,11 @@ exports.defineAutoTests = function () {
describe("Round trip Contact tests (creating + save + delete + find).", function () {
afterEach(removeContact);
- it("contacts.spec.24 Creating, saving, finding a contact should work, removing it should work, after which we should not be able to find it, and we should not be able to delete it again.", function(done) {
+ it("contacts.spec.24 Creating, saving, finding a contact should work, removing it should work, after which we should not be able to find it, and we should not be able to delete it again.", function (done) {
+ if (isWindowsPhone) {
+ done();
+ return;
+ }
gContactObj = new Contact();
gContactObj.name = new ContactName();
gContactObj.name.familyName = "DeleteMe";
[2/2] git commit: Merge branch 'skipOnWindows' of
https://github.com/stacic/cordova-plugin-contacts
Posted by mm...@apache.org.
Merge branch 'skipOnWindows' of https://github.com/stacic/cordova-plugin-contacts
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/79c7a1ba
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/79c7a1ba
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/79c7a1ba
Branch: refs/heads/master
Commit: 79c7a1baaa8edec1e206a3a6dcc626bd5ae3fec5
Parents: d5c1126 ceed0b7
Author: Michal Mocny <mm...@gmail.com>
Authored: Fri Aug 15 14:16:39 2014 -0400
Committer: Michal Mocny <mm...@gmail.com>
Committed: Fri Aug 15 14:16:39 2014 -0400
----------------------------------------------------------------------
tests/tests.js | 39 +++++++++++++++++++++++++++++++++------
1 file changed, 33 insertions(+), 6 deletions(-)
----------------------------------------------------------------------