You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/24 17:05:25 UTC
[GitHub] [submarine] HuangTing-Yao opened a new pull request #248:
SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
HuangTing-Yao opened a new pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248
### What is this PR for?
Change spark 2.4.4 to 2.3.4 , because the link only support spark 2.3.4 .
Manual install some packages which will connect fail when it auto install .
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-453
### How should this be tested?
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] asfgit closed pull request #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] liuxunorg commented on issue #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-604177458
@HuangTing-Yao
Can you attach a screenshot of the successful build mini-submarine docker image in PR `Screenshots (if appropriate)` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] HuangTing-Yao commented on issue #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-604199907
@liuxunorg Screenshots update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on a change in pull request #248:
SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#discussion_r397957788
##########
File path: dev-support/mini-submarine/Dockerfile
##########
@@ -16,6 +16,14 @@
FROM ubuntu:18.04
#INSTALL JAVA
RUN apt-get -q update \
+ && apt-get install -y wget \
+ && apt-get install -y software-properties-common \
Review comment:
```suggestion
&& apt-get install -y wget software-properties-common \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on a change in pull request #248:
SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#discussion_r397955676
##########
File path: dev-support/mini-submarine/Dockerfile
##########
@@ -16,6 +16,14 @@
FROM ubuntu:18.04
#INSTALL JAVA
RUN apt-get -q update \
+ && apt-get install -y wget \
Review comment:
```suggestion
&& apt-get install -y wget software-properties-common \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] tangzhankun edited a comment on issue #248:
SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
tangzhankun edited a comment on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-604798129
@HuangTing-Yao Thanks for the contribution. LGTM. +1.
One question not related to this PR,
Is the TF2 installation in Dockerfile a must? That costs me 20mins+ to get it ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] tangzhankun commented on issue #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-605550043
@pingsutw @HuangTing-Yao Thanks for the explanation. Will merge it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] HuangTing-Yao commented on a change in pull request
#248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on a change in pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#discussion_r398005611
##########
File path: dev-support/mini-submarine/Dockerfile
##########
@@ -16,6 +16,14 @@
FROM ubuntu:18.04
#INSTALL JAVA
RUN apt-get -q update \
+ && apt-get install -y wget \
+ && apt-get install -y software-properties-common \
Review comment:
I had update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] tangzhankun commented on issue #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-604798129
@HuangTing-Yao Thanks for the contribution. LGTM. +1.
One question,
Is the TF2 installation in Dockerfile a must? That costs me 20mins+ to get it ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on a change in pull request #248:
SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#discussion_r397955676
##########
File path: dev-support/mini-submarine/Dockerfile
##########
@@ -16,6 +16,14 @@
FROM ubuntu:18.04
#INSTALL JAVA
RUN apt-get -q update \
+ && apt-get install -y wget \
Review comment:
```suggestion
&& apt-get install -y wget software-properties-common \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] pingsutw commented on issue #248: SUBMARINE-453.
Mini-submarine build_mini-submarine.sh get error
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #248: SUBMARINE-453. Mini-submarine build_mini-submarine.sh get error
URL: https://github.com/apache/submarine/pull/248#issuecomment-604808068
@tangzhankun there is a tf2 mnist example in mini-submarine so that we need to install tf2 in Dockerfile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services