You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2016/12/04 22:24:13 UTC
Re: logging-log4j2 git commit: [LOG4J2-1723]
Shouldn't the change log entry be something like "Removed unwanted transitive dependency on geronimo-jms_1.1_spec to allow OSGi tests to pass."?
Sent from my iPhone
> On 5 Dec 2016, at 3:19, ggregory@apache.org wrote:
>
> Repository: logging-log4j2
> Updated Branches:
> refs/heads/master 19ac9876f -> e0d9aa76b
>
>
> [LOG4J2-1723]
>
> Unwanted transitive dependency on geronimo-jms_1.1_spec causes OSGi
> tests to fail.
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e0d9aa76
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e0d9aa76
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e0d9aa76
>
> Branch: refs/heads/master
> Commit: e0d9aa76b8b960f97577e6dffb923cf1376e95ff
> Parents: 19ac987
> Author: Gary Gregory <gg...@apache.org>
> Authored: Sun Dec 4 10:19:11 2016 -0800
> Committer: Gary Gregory <gg...@apache.org>
> Committed: Sun Dec 4 10:19:11 2016 -0800
>
> ----------------------------------------------------------------------
> log4j-core/pom.xml | 6 ++++++
> src/changes/changes.xml | 3 +++
> 2 files changed, 9 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0d9aa76/log4j-core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/log4j-core/pom.xml b/log4j-core/pom.xml
> index 5228a8d..0f19606 100644
> --- a/log4j-core/pom.xml
> +++ b/log4j-core/pom.xml
> @@ -234,6 +234,12 @@
> <groupId>org.apache.activemq</groupId>
> <artifactId>activemq-broker</artifactId>
> <scope>test</scope>
> + <exclusions>
> + <exclusion>
> + <groupId>org.apache.geronimo.specs</groupId>
> + <artifactId>geronimo-jms_1.1_spec</artifactId>
> + </exclusion>
> + </exclusions>
> </dependency>
> <dependency>
> <groupId>commons-logging</groupId>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0d9aa76/src/changes/changes.xml
> ----------------------------------------------------------------------
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index 8830609..1280d14 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -138,6 +138,9 @@
> <action issue="LOG4J2-1676" dev="ggregory" type="fix" due-to="Joern Huxhorn">
> Some LogEvents may not carry a Throwable (Use Message.getThrowable() in log(Message) methods.)
> </action>
> + <action issue="LOG4J2-1723" dev="ggregory" type="fix" due-to="Ludovic HOCHET">
> + Unwanted transitive dependency on geronimo-jms_1.1_spec causes OSGi tests to fail.
> + </action>
> <action issue="LOG4J2-1644" dev="ggregory" type="update" due-to="Tim Gokcen, Pavel Sivolobtchik">
> Inefficient locking in AbstractLoggerAdapter.
> </action>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: logging-log4j2 git commit: [LOG4J2-1723]
Posted by Remko Popma <re...@gmail.com>.
What I'm suggesting is to write change logs from the user's POV.
The JIRA reports the problem, the change log allows users to quickly find what changed between releases and why.
Sent from my iPhone
> On 5 Dec 2016, at 8:36, Gary Gregory <ga...@gmail.com> wrote:
>
> I just put the title of the JIRA in there.
>
> Gary
>
>> On Sun, Dec 4, 2016 at 2:24 PM, Remko Popma <re...@gmail.com> wrote:
>> Shouldn't the change log entry be something like "Removed unwanted transitive dependency on geronimo-jms_1.1_spec to allow OSGi tests to pass."?
>>
>> Sent from my iPhone
>>
>> > On 5 Dec 2016, at 3:19, ggregory@apache.org wrote:
>> >
>> > Repository: logging-log4j2
>> > Updated Branches:
>> > refs/heads/master 19ac9876f -> e0d9aa76b
>> >
>> >
>> > [LOG4J2-1723]
>> >
>> > Unwanted transitive dependency on geronimo-jms_1.1_spec causes OSGi
>> > tests to fail.
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e0d9aa76
>> > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e0d9aa76
>> > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e0d9aa76
>> >
>> > Branch: refs/heads/master
>> > Commit: e0d9aa76b8b960f97577e6dffb923cf1376e95ff
>> > Parents: 19ac987
>> > Author: Gary Gregory <gg...@apache.org>
>> > Authored: Sun Dec 4 10:19:11 2016 -0800
>> > Committer: Gary Gregory <gg...@apache.org>
>> > Committed: Sun Dec 4 10:19:11 2016 -0800
>> >
>> > ----------------------------------------------------------------------
>> > log4j-core/pom.xml | 6 ++++++
>> > src/changes/changes.xml | 3 +++
>> > 2 files changed, 9 insertions(+)
>> > ----------------------------------------------------------------------
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0d9aa76/log4j-core/pom.xml
>> > ----------------------------------------------------------------------
>> > diff --git a/log4j-core/pom.xml b/log4j-core/pom.xml
>> > index 5228a8d..0f19606 100644
>> > --- a/log4j-core/pom.xml
>> > +++ b/log4j-core/pom.xml
>> > @@ -234,6 +234,12 @@
>> > <groupId>org.apache.activemq</groupId>
>> > <artifactId>activemq-broker</artifactId>
>> > <scope>test</scope>
>> > + <exclusions>
>> > + <exclusion>
>> > + <groupId>org.apache.geronimo.specs</groupId>
>> > + <artifactId>geronimo-jms_1.1_spec</artifactId>
>> > + </exclusion>
>> > + </exclusions>
>> > </dependency>
>> > <dependency>
>> > <groupId>commons-logging</groupId>
>> >
>> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0d9aa76/src/changes/changes.xml
>> > ----------------------------------------------------------------------
>> > diff --git a/src/changes/changes.xml b/src/changes/changes.xml
>> > index 8830609..1280d14 100644
>> > --- a/src/changes/changes.xml
>> > +++ b/src/changes/changes.xml
>> > @@ -138,6 +138,9 @@
>> > <action issue="LOG4J2-1676" dev="ggregory" type="fix" due-to="Joern Huxhorn">
>> > Some LogEvents may not carry a Throwable (Use Message.getThrowable() in log(Message) methods.)
>> > </action>
>> > + <action issue="LOG4J2-1723" dev="ggregory" type="fix" due-to="Ludovic HOCHET">
>> > + Unwanted transitive dependency on geronimo-jms_1.1_spec causes OSGi tests to fail.
>> > + </action>
>> > <action issue="LOG4J2-1644" dev="ggregory" type="update" due-to="Tim Gokcen, Pavel Sivolobtchik">
>> > Inefficient locking in AbstractLoggerAdapter.
>> > </action>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: logging-log4j2 git commit: [LOG4J2-1723]
Posted by Gary Gregory <ga...@gmail.com>.
I just put the title of the JIRA in there.
Gary
On Sun, Dec 4, 2016 at 2:24 PM, Remko Popma <re...@gmail.com> wrote:
> Shouldn't the change log entry be something like "Removed unwanted
> transitive dependency on geronimo-jms_1.1_spec to allow OSGi tests to
> pass."?
>
> Sent from my iPhone
>
> > On 5 Dec 2016, at 3:19, ggregory@apache.org wrote:
> >
> > Repository: logging-log4j2
> > Updated Branches:
> > refs/heads/master 19ac9876f -> e0d9aa76b
> >
> >
> > [LOG4J2-1723]
> >
> > Unwanted transitive dependency on geronimo-jms_1.1_spec causes OSGi
> > tests to fail.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/e0d9aa76
> > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/
> e0d9aa76
> > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/
> e0d9aa76
> >
> > Branch: refs/heads/master
> > Commit: e0d9aa76b8b960f97577e6dffb923cf1376e95ff
> > Parents: 19ac987
> > Author: Gary Gregory <gg...@apache.org>
> > Authored: Sun Dec 4 10:19:11 2016 -0800
> > Committer: Gary Gregory <gg...@apache.org>
> > Committed: Sun Dec 4 10:19:11 2016 -0800
> >
> > ----------------------------------------------------------------------
> > log4j-core/pom.xml | 6 ++++++
> > src/changes/changes.xml | 3 +++
> > 2 files changed, 9 insertions(+)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> e0d9aa76/log4j-core/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/log4j-core/pom.xml b/log4j-core/pom.xml
> > index 5228a8d..0f19606 100644
> > --- a/log4j-core/pom.xml
> > +++ b/log4j-core/pom.xml
> > @@ -234,6 +234,12 @@
> > <groupId>org.apache.activemq</groupId>
> > <artifactId>activemq-broker</artifactId>
> > <scope>test</scope>
> > + <exclusions>
> > + <exclusion>
> > + <groupId>org.apache.geronimo.specs</groupId>
> > + <artifactId>geronimo-jms_1.1_spec</artifactId>
> > + </exclusion>
> > + </exclusions>
> > </dependency>
> > <dependency>
> > <groupId>commons-logging</groupId>
> >
> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> e0d9aa76/src/changes/changes.xml
> > ----------------------------------------------------------------------
> > diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> > index 8830609..1280d14 100644
> > --- a/src/changes/changes.xml
> > +++ b/src/changes/changes.xml
> > @@ -138,6 +138,9 @@
> > <action issue="LOG4J2-1676" dev="ggregory" type="fix"
> due-to="Joern Huxhorn">
> > Some LogEvents may not carry a Throwable (Use
> Message.getThrowable() in log(Message) methods.)
> > </action>
> > + <action issue="LOG4J2-1723" dev="ggregory" type="fix"
> due-to="Ludovic HOCHET">
> > + Unwanted transitive dependency on geronimo-jms_1.1_spec causes
> OSGi tests to fail.
> > + </action>
> > <action issue="LOG4J2-1644" dev="ggregory" type="update"
> due-to="Tim Gokcen, Pavel Sivolobtchik">
> > Inefficient locking in AbstractLoggerAdapter.
> > </action>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory