[GitHub] [flink] tillrohrmann commented on a change in pull request #14483: [FLINK-18998][Runtime / Web Frontend]No watermark is shown on Flink UI when ProcessingTime is used

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #14483:
URL: https://github.com/apache/flink/pull/14483#discussion_r549319347



##########
File path: flink-runtime-web/web-dashboard/src/app/share/pipes/humanize-watermark.pipe.ts
##########
@@ -24,7 +24,9 @@ import { LONG_MIN_VALUE } from 'config';
 })
 export class HumanizeWatermarkPipe implements PipeTransform {
   transform(value: any): any {
-    if (isNaN(value) || value <= LONG_MIN_VALUE) {
+    if (isNaN(value)) {
+      return 'Watermarks are only available if EventTime is used';
+    } else if (value <= LONG_MIN_VALUE) {
       return 'No Watermark';

Review comment:
       I am not sure whether this change does the trick because if a user selects processing time as the time characteristic, then Flink will report `Long.MIN_VALUE` back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org