[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1449: MINIFICPP-1978 - Flush MergeContent bundles when its size would grow beyond max group size

[GitBox <gi...@apache.org>]

adamdebreceni commented on code in PR #1449:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1449#discussion_r1017906452


##########
extensions/libarchive/BinFiles.h:
##########
@@ -87,8 +87,10 @@ class Bin {
       }
     }
 
-    if ((queued_data_size_ + flow->getSize()) > maxSize_ || (queue_.size() + 1) > maxEntries_)
+    if ((queued_data_size_ + flow->getSize()) > maxSize_ || (queue_.size() + 1) > maxEntries_) {
+      closed_ = true;

Review Comment:
   incoming flow files that are larger than max group size are immediately assigned their own bin, and flushed by themselves, so they won't be a problem, flow files that are large but not max size large, could cause the flush of a single bin, as we only try to insert into a single bin (the last in the group's queue) before creating a new bin for it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org