[GitHub] [hive] ayushtkn commented on a diff in pull request #3187: HIVE-26074: PTF Vectorization: BoundaryScanner for varchar.

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #3187:
URL: https://github.com/apache/hive/pull/3187#discussion_r845927749


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java:
##########
@@ -768,6 +774,9 @@ public static SingleValueBoundaryScanner getBoundaryScanner(BoundaryDef start, B
     case "string":
       return new StringPrimitiveValueBoundaryScanner(start, end, exprDef, nullsLast);
     default:
+      if (typeString.startsWith("char") || typeString.startsWith("varchar")) {

Review Comment:
   can't do that. the entries aren't fixed char or varchar, they are like char(10) or char(5) or varchar(5) or varchar(6) like that. So putting char or varchar in switch-case won't work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org