You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/11 16:35:36 UTC
Review Request 46026: Documented `Socket::shutdown()` member function
in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46026/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
This is slightly confusing, because it doesn't match the
semantics of the shutdown(2) POSIX function.
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp 4cb49680d1304899a4ee675ac07379e51d9c55b1
Diff: https://reviews.apache.org/r/46026/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 46026: Documented `Socket::shutdown()` member
function in libprocess.
Posted by Neil Conway <ne...@gmail.com>.
> On April 11, 2016, 9:46 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 176-187
> > <https://reviews.apache.org/r/46026/diff/1/?file=1339341#file1339341line176>
> >
> > Why don't we instead take the "`int how`" as an argument and make the SHUT_RD explicit in the callers? This interface had come up in the past, would like to see from benh/joris if there's any that the SHUT_RD was made implicit and no control was given to the caller.
No objection from me -- I just assumed there was a reason we were choosing to deviate from how `shutdown(2)` works.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46026/#review128261
-----------------------------------------------------------
On April 11, 2016, 2:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46026/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 2:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is slightly confusing, because it doesn't match the
> semantics of the shutdown(2) POSIX function.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 4cb49680d1304899a4ee675ac07379e51d9c55b1
>
> Diff: https://reviews.apache.org/r/46026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46026: Documented `Socket::shutdown()` member
function in libprocess.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46026/#review128261
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp (lines 176 - 187)
<https://reviews.apache.org/r/46026/#comment191681>
Why don't we instead take the "`int how`" as an argument and make the SHUT_RD explicit in the callers? This interface had come up in the past, would like to see from benh/joris if there's any that the SHUT_RD was made implicit and no control was given to the caller.
- Ben Mahler
On April 11, 2016, 2:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46026/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 2:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is slightly confusing, because it doesn't match the
> semantics of the shutdown(2) POSIX function.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 4cb49680d1304899a4ee675ac07379e51d9c55b1
>
> Diff: https://reviews.apache.org/r/46026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>