You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shoelsch <gi...@git.apache.org> on 2016/02/05 03:49:50 UTC
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
GitHub user shoelsch opened a pull request:
https://github.com/apache/spark/pull/11087
[SPARK-13179] [Python] Fix PySpark Row name collision 'count'
Override PySpark Row inherited count method to instead get "count" column name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shoelsch/spark SPARK-13179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11087
----
commit 0ddd3708b457b2ecc44d9c678272f800b8b0439c
Author: Steven Hoelscher <st...@zillow.com>
Date: 2016-02-05T02:45:13Z
Override PySpark Row inherited count method to instead get "count" column name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-180218453
Is there a test we can add?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by shoelsch <gi...@git.apache.org>.
Github user shoelsch commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-180229059
I can add a test that checks if Row.count has a __call__ attribute.
```
from pyspark.sql import Row
row = Row('count')
assertFalse(hasattr(row(1).count, '__call__'))
assertEqual(row(1).count, 1)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-212018233
@shoelsch Since we have workaround for this (`row["count"]` or access it by index), I'd like to not have these special cases. Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-211690078
re-ping @davies is this a change we want?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by shoelsch <gi...@git.apache.org>.
Github user shoelsch closed the pull request at:
https://github.com/apache/spark/pull/11087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-180167306
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13179] [Python] Fix PySpark Row name co...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11087#issuecomment-180218507
cc @davies i'm not sure whether this is a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org