You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by klopfdreh <gi...@git.apache.org> on 2016/11/25 14:40:20 UTC
[GitHub] wicket pull request #195: WICKET-6287 Switch from json.org to open-json - 7....
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/195
WICKET-6287 Switch from json.org to open-json - 7.x
There are clirr errors, because of some classes missing in open-json
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket WICKET-6287_7.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit cc057d0cca748c537762b3ed354dc795c455a424
Author: Tobias Soloschenko <ts...@apache.org>
Date: 2016-11-25T07:29:40Z
WICKET-6287 Switch from json.org to open-json - 7.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Thanks a lot @tdunning !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
That's a different problem though (and it worked for me too). I'm building 5bfa280b2b7fb9dc7861d582a9c6e37d106be879 locally now to see what it does (the one you linked to)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@bitstorm - the changes are made - JSONObject does not throw any checked exceptions anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Closed due to:
* https://github.com/apache/wicket/commit/3dacec4c55bb95618f604ad2ccea279346de279c
* https://github.com/apache/wicket/commit/6b1d53b17a0aa77a8b131fd161e12e08d335a251
* https://github.com/apache/wicket/commit/5348b3e00518e5636126e724f1e62ea1aebbd8b6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by Tobias Soloschenko <to...@googlemail.com>.
I edited the message on github. See the updated one there.
kind regards
Tobias
> Am 10.01.2017 um 08:02 schrieb klopfdreh <gi...@git.apache.org>:
>
> Github user klopfdreh commented on the issue:
>
> https://github.com/apache/wicket/pull/195
>
> Hi @bitstorm ,
> I saw that JSONObject throws a JSONException which extends RuntimeException - I thought it is unchecked.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Hi @bitstorm ,
I saw that JSONObject throws a JSONException which extends RuntimeException - I thought it is unchecked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
@martin-g I hate German translations of computer terms, which is the main reason my systems are all in English. But as mentioned elsewhere, I use a split locale instead, with formatting set to German. Thus I break things in other ways ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@martin-g , @dashorst , @bitstorm - would you be so kind and review the changes / check if there are no clirr issues for the 7.x branch? I don't have jdk 7 installed so I get a "Invalid byte tag in constant pool: 18" of clirr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
I managed to resolve the clirr issues.
What I did was:
* Revert back all class signatures that were copied from json.org and throw a corresponding exception to inform users about the switch
If the user updates Apache Wicket and is ok with the license issue of JSON.org the users code has to be switched to the corresponding maven dependency of the JSON.org library and the imports has to be reorganized, but for 90% the code will work as before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
Compilation and Clirr pass but a test fails:
```
Failed tests:
CssUrlReplacerTest.base64EncodedImage:165->Assert.assertThat:923->Assert.assertThat:956
Expected: a string containing ".class {background-image: url(data:image/gif;base64,R0lGODlh1wATAXAAACH5BAEAAP8ALAAAAADXA"
but: was ".class {background-image: url(data:image/gif;base64,R0lGODlhUAB4ANUAANbX1hQSEXV0c/fz8tCBfc3NzFBNTPO6ttzIx/LKyIGAf84jGri4t9avrainppiXlut9dqZSTI41MNzDwbCMitWQjLF0cJVzcc52cctKQ8zW1sLCwe+WkdnQz8U4MIVaWFxaWYuJiKg+Oa2sq52dnMygncvOz83QzzAuLbdbVpKRkEJAP9LDwpxmY+enpN3c3NLR0WdmZcnIyLKxsPHl5L++vc5oY8rLyuO9vMfGxuxqY6OhodZYUcXFxM7Ozv///yH5BAAAAAAALAAAAABQAHgAAAb/wJ9wSCwaj0jjAEFpfZwt54XSGSSv2Kw2OZh9QJ9paUwpfy+srXrNfkEpjdcuJqgNdiRW86Oysv+ARAhOIR01MQMOKCs7PyAqPw......
````
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
I figured out to do
$ git fetch github-upstream refs/pull/195/head
$ git checkout FETCH_HEAD
From that I got commit 4dbdbdfe, and that builds cleanly for me. I also tried to just run that particular test in IDEA, and it worked too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by tdunning <gi...@git.apache.org>.
Github user tdunning commented on the issue:
https://github.com/apache/wicket/pull/195
Should get that release out later today.
On Thu, Jan 19, 2017 at 11:29 AM, Tobias Soloschenko <
notifications@github.com> wrote:
> @bitstorm <https://github.com/bitstorm> - the issue about the checked
> exceptions is fixed in the master branch we only have to wait until the
> release and increase our version in the pom.xml. Then there should be no
> further issue.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/wicket/pull/195#issuecomment-273873780>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAPSeuwHYOQSm09tF5fbT6vB5vcXRb8Pks5rT7mCgaJpZM4K8fqL>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on the issue:
https://github.com/apache/wicket/pull/195
@klopfdreh
Hi,
One minor issue I've seen with this PR is that now ' new JSONObject' throws checked exceptions, so the code must be adapted some how. This happened with WicketStuff [here](https://travis-ci.org/wicketstuff/core/builds/188994145). It's not a big issue, but maybe this could be a problem with other libraries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
I don't think this is regarding the JSON change. The String is to long and it is a different as the expected one and the CssUrlReplacer don't use JSON at all (only regex) - maybe it has something to do with the locale changes? (Only an assumption)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
This might be a stupid question, but I must be missing something. How do I check out the pull request branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
Oh, you mean a problem on your machine? If that's the case, I'll stop trying to recreate it here ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Haha @duesenklipper - you wrote a bit earlier - yep I know the CssUrlReplacer and @martin-g , too. We implemented it \U0001f60a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
I changed the method propertiesAsMap to throw the JSONException, because the first statement of a constructor always has to be the super / this call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
@klopfdreh I don't think it does. It appears to be a problem on @martin-g's machine. The JSON stuff doesn't even come close to CssUrlReplacer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
fyi @martin-g
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@martin-g I rebased it and pushed it again. Should be up to date now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
The problem seems to be here.
BuildBot passes the build until Arquilian tests: https://ci.apache.org/builders/wicket-branch-7.x/builds/333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Summary before integration:
* json.org is replaced with open-json, now
* Method calls not supported by open-json throw a WicketRuntimeException to inform the user
* If the users still needs json.org they have to reorganize imports and add the json.org dependency in maven (beware of the license issues in this case!!)
* All classes are preserved due to clirr checks, but are converted to dummies if there is no functionality left
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by tdunning <gi...@git.apache.org>.
Github user tdunning commented on the issue:
https://github.com/apache/wicket/pull/195
The artifacts for version 1.8 Open Json are on central.
https://repo1.maven.org/maven2/com/tdunning/json/1.8/
On Thu, Jan 19, 2017 at 11:44 AM, Tobias Soloschenko <
notifications@github.com> wrote:
> Thanks a lot @tdunning <https://github.com/tdunning> !
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/wicket/pull/195#issuecomment-273877731>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAPSeqZiYOyPvjpxOA4khkQgBk3PZVDhks5rT70MgaJpZM4K8fqL>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
I was saying that if BuildBot is fine (at wicket-core) then the problem must be here.
The problem with Arquillian is known. It waits someone to debug it. Too bad the JavaEE fans do not give it more love :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
(that said, that test works in the original wicket-7.x branch. i'll try and figure this out as soon as i can get at the branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
The build passes with JDK1.7!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #195: WICKET-6287 Switch from json.org to open-json - 7....
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Hi,
after some research I found out that there is no way to use open-json without API breaks, because it uses the same class names / methods so that you can't redirect the calls, also the API is slightly different in some places. I just tried to implement the missing classes with stubs that only throws RuntimeExceptions so that the API is preserved, but without success.
This also affects the PR https://github.com/apache/wicket/pull/194
I would suggest to go for it anyway, because open-json mostly the same as json.org
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
(I ran `mvn clean package`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
@duesenklipper I am the non-German guy here but it seems it is just me who uses de_DE locale to catch such kind of problems :-) Your fix is good!
@klopfdreh Please update this branch to latest wicket-7.x and I'll retest it again with JDK1.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by duesenklipper <gi...@git.apache.org>.
Github user duesenklipper commented on the issue:
https://github.com/apache/wicket/pull/195
@klopfdreh I know you did ;-)
@martin-g I found it. @klopfdreh is right, it has something to do with Locale. My fault - for some reason I lost the `@Before` method in `CssUrlReplacerTest` that set the Locale to English, when I updated that test for data urls. I'll push the fix to the main branches. Sorry about that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on the issue:
https://github.com/apache/wicket/pull/195
thank you all!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
To come to the point: In which way the JSON lib change affects CssUrlReplacerTest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Great! \U0001f604 - so if everything is working - we should integrate all PR for open-json. But I suggest to test all dependencies (also for wicketstuff)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
The build fails for me at branch `wicket-7.x` with the same error as in this PR.
I merge PRs from Github with https://github.com/martin-g/dotfiles/blob/master/bin/github-pr.sh:
- $ cd ~/git/apache/wicket-7.x
- $ github-pr.sh 195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/195
wicket-7.x fails the same way.
@duesenklipper Ping!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@bitstorm - the issue about the checked exceptions is fixed in the master branch we only have to wait until the release and increase our version in the pom.xml. Then there should be no further issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---