[GitHub] [incubator-iceberg] Fokko commented on a change in pull request #708: Bump Apache Parquet to 1.11.0

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #708: Bump Apache Parquet to 1.11.0
URL: https://github.com/apache/incubator-iceberg/pull/708#discussion_r368991573
 
 

 ##########
 File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
 ##########
 @@ -171,8 +191,8 @@ private void startRowGroup() {
     this.nextCheckRecordCount = Math.min(Math.max(recordCount / 2, 100), 10000);
     this.recordCount = 0;
 
-    PageWriteStore pageStore = pageStoreCtor.newInstance(
-        compressor, parquetSchema, props.getAllocator());
+    PageWriteStore pageStore = pageStoreCtorParquet.newInstance(
+          compressor, parquetSchema, props.getAllocator(), Integer.MAX_VALUE);
 
 Review comment:
   Good question. The int will be truncated: https://github.com/apache/incubator-iceberg/blob/master/common/src/main/java/org/apache/iceberg/common/DynConstructors.java#L57
   
   I was under the impression that the `DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH` was `Integer.MAX_VALUE`, thanks for pointing out. I've also set the default to 64 in Iceberg. I did not want to use `ParquetProperties.DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH` because that one is not available in Parquet 1.10.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org