You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/06 01:10:16 UTC
[GitHub] [zookeeper] KangZhiDong opened a new pull request #1570: ZOOKEEPER-4046:Fix typo
KangZhiDong opened a new pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570
Fix typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] KangZhiDong commented on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
KangZhiDong commented on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-765059700
> @KangZhiDong
> Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's also my first-time to merge a PR :)
tks dalao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-764825667
@KangZhiDong
Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's my first-time to merge a PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] KangZhiDong commented on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
KangZhiDong commented on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-765059700
> @KangZhiDong
> Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's also my first-time to merge a PR :)
tks dalao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on a change in pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#discussion_r553923081
##########
File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md
##########
@@ -121,9 +121,9 @@ limitations under the License.
- ZooKeeper maintains ephemeral cluster membership information. The Drillbits use ZooKeeper to find other Drillbits in the cluster,
and the client uses ZooKeeper to find Drillbits to submit a query [28].
-### [Apache Druid(Incubating)](https://druid.apache.org/)
- - Apache Druid (incubating) is a high performance real-time analytics database.
- - Apache Druid (incubating) uses Apache ZooKeeper (ZK) for management of current cluster state. The operations that happen over ZK are [27]:
+### [Apache Druid](https://druid.apache.org/)
+ - Apache Druid is a high performance real-time analytics database.
+ - Apache Druid uses Apache ZooKeeper (ZK) for management of current cluster state. The operations that happen over ZK are [27]:
- Coordinator leader election
- Segment "publishing" protocol from Historical and Realtime
Review comment:
- Yes, Apache Druid has graduated on `2019-12-18` (https://incubator.apache.org/projects/druid.html).
- When I wrote this doc, it still was in a incubating state. so it may not be a typo? Of course, we should update it now.
- Others lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling edited a comment on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling edited a comment on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-764825667
@KangZhiDong
Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's also my first-time to merge a PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-764825667
@KangZhiDong
Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's my first-time to merge a PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on a change in pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#discussion_r553923081
##########
File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md
##########
@@ -121,9 +121,9 @@ limitations under the License.
- ZooKeeper maintains ephemeral cluster membership information. The Drillbits use ZooKeeper to find other Drillbits in the cluster,
and the client uses ZooKeeper to find Drillbits to submit a query [28].
-### [Apache Druid(Incubating)](https://druid.apache.org/)
- - Apache Druid (incubating) is a high performance real-time analytics database.
- - Apache Druid (incubating) uses Apache ZooKeeper (ZK) for management of current cluster state. The operations that happen over ZK are [27]:
+### [Apache Druid](https://druid.apache.org/)
+ - Apache Druid is a high performance real-time analytics database.
+ - Apache Druid uses Apache ZooKeeper (ZK) for management of current cluster state. The operations that happen over ZK are [27]:
- Coordinator leader election
- Segment "publishing" protocol from Historical and Realtime
Review comment:
- Yes, Apache Druid has graduated on `2019-12-18` (https://incubator.apache.org/projects/druid.html).
- When I wrote this doc, it still was in a incubating state. so it may not be a typo? Of course, we should update it now.
- Others lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling edited a comment on pull request #1570: ZOOKEEPER-4046:Fix typo
Posted by GitBox <gi...@apache.org>.
maoling edited a comment on pull request #1570:
URL: https://github.com/apache/zookeeper/pull/1570#issuecomment-764825667
@KangZhiDong
Thanks for your contribution. I observe it's your first-time contribution to zookeeper project and it's also my first-time to merge a PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org