You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "David Liu (JIRA)" <ji...@apache.org> on 2011/06/01 11:29:48 UTC

[jira] [Created] (CXF-3564) SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus

SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus
---------------------------------------------------------------------------------

                 Key: CXF-3564
                 URL: https://issues.apache.org/jira/browse/CXF-3564
             Project: CXF
          Issue Type: Bug
    Affects Versions: 2.4
            Reporter: David Liu


  It could be a bug in SpringBusFactory that it does not read META-INF/cxf/cxf.extension file which contains additional cxf extension config files. However, it uses to read META-INF/cxf/cxf.extension in 2.2.

  Reason: In CXF 2.2, SpringBusFactory will always create BusApplicationContext to read META-INF/cxf/cxf.extension when cfgFile is null, However, CXF 2.4 does not create BusApplicationContext when cfgFile is null. I think it is a bug in CXF 2.4 because it will ignore the extions in cxf.extension file

Code: when cfgFiles is null, SpringBusFactory will not create BusApplicationContext to read META-INF/cxf/cxf.extension file. 
{code}
    public Bus createBus(String cfgFiles[], boolean includeDefaults) {
        try {
            String userCfgFile = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_NAME);
            String sysCfgFileUrl = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_URL);
            Resource r = BusApplicationContext.findResource(Configurer.DEFAULT_USER_CFG_FILE);
            if (context == null && userCfgFile == null && cfgFiles == null && sysCfgFileUrl == null 
                && (r == null || !r.exists()) && includeDefaults) {
                return new org.apache.cxf.bus.CXFBusFactory().createBus();
            }
            return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
            return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
{code}
   
   Could you please fix it?

Cheers,
David

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CXF-3564) SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus

Posted by "David Liu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042571#comment-13042571 ] 

David Liu commented on CXF-3564:
--------------------------------

Got it, thanks.

David

> SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus
> ---------------------------------------------------------------------------------
>
>                 Key: CXF-3564
>                 URL: https://issues.apache.org/jira/browse/CXF-3564
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: David Liu
>            Assignee: Freeman Fang
>
>   It could be a bug in SpringBusFactory that it does not read META-INF/cxf/cxf.extension file which contains additional cxf extension config files. However, it uses to read META-INF/cxf/cxf.extension in 2.2.
>   Reason: In CXF 2.2, SpringBusFactory will always create BusApplicationContext to read META-INF/cxf/cxf.extension when cfgFile is null, However, CXF 2.4 does not create BusApplicationContext when cfgFile is null. I think it is a bug in CXF 2.4 because it will ignore the extions in cxf.extension file
> Code: when cfgFiles is null, SpringBusFactory will not create BusApplicationContext to read META-INF/cxf/cxf.extension file. 
> {code}
>     public Bus createBus(String cfgFiles[], boolean includeDefaults) {
>         try {
>             String userCfgFile = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_NAME);
>             String sysCfgFileUrl = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_URL);
>             Resource r = BusApplicationContext.findResource(Configurer.DEFAULT_USER_CFG_FILE);
>             if (context == null && userCfgFile == null && cfgFiles == null && sysCfgFileUrl == null 
>                 && (r == null || !r.exists()) && includeDefaults) {
>                 return new org.apache.cxf.bus.CXFBusFactory().createBus();
>             }
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
> {code}
>    
>    Could you please fix it?
> Cheers,
> David

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CXF-3564) SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved CXF-3564.
-------------------------------

    Resolution: Not A Problem

> SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus
> ---------------------------------------------------------------------------------
>
>                 Key: CXF-3564
>                 URL: https://issues.apache.org/jira/browse/CXF-3564
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: David Liu
>            Assignee: Freeman Fang
>
>   It could be a bug in SpringBusFactory that it does not read META-INF/cxf/cxf.extension file which contains additional cxf extension config files. However, it uses to read META-INF/cxf/cxf.extension in 2.2.
>   Reason: In CXF 2.2, SpringBusFactory will always create BusApplicationContext to read META-INF/cxf/cxf.extension when cfgFile is null, However, CXF 2.4 does not create BusApplicationContext when cfgFile is null. I think it is a bug in CXF 2.4 because it will ignore the extions in cxf.extension file
> Code: when cfgFiles is null, SpringBusFactory will not create BusApplicationContext to read META-INF/cxf/cxf.extension file. 
> {code}
>     public Bus createBus(String cfgFiles[], boolean includeDefaults) {
>         try {
>             String userCfgFile = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_NAME);
>             String sysCfgFileUrl = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_URL);
>             Resource r = BusApplicationContext.findResource(Configurer.DEFAULT_USER_CFG_FILE);
>             if (context == null && userCfgFile == null && cfgFiles == null && sysCfgFileUrl == null 
>                 && (r == null || !r.exists()) && includeDefaults) {
>                 return new org.apache.cxf.bus.CXFBusFactory().createBus();
>             }
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
> {code}
>    
>    Could you please fix it?
> Cheers,
> David

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CXF-3564) SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned CXF-3564:
---------------------------------

    Assignee: Freeman Fang

> SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus
> ---------------------------------------------------------------------------------
>
>                 Key: CXF-3564
>                 URL: https://issues.apache.org/jira/browse/CXF-3564
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: David Liu
>            Assignee: Freeman Fang
>
>   It could be a bug in SpringBusFactory that it does not read META-INF/cxf/cxf.extension file which contains additional cxf extension config files. However, it uses to read META-INF/cxf/cxf.extension in 2.2.
>   Reason: In CXF 2.2, SpringBusFactory will always create BusApplicationContext to read META-INF/cxf/cxf.extension when cfgFile is null, However, CXF 2.4 does not create BusApplicationContext when cfgFile is null. I think it is a bug in CXF 2.4 because it will ignore the extions in cxf.extension file
> Code: when cfgFiles is null, SpringBusFactory will not create BusApplicationContext to read META-INF/cxf/cxf.extension file. 
> {code}
>     public Bus createBus(String cfgFiles[], boolean includeDefaults) {
>         try {
>             String userCfgFile = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_NAME);
>             String sysCfgFileUrl = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_URL);
>             Resource r = BusApplicationContext.findResource(Configurer.DEFAULT_USER_CFG_FILE);
>             if (context == null && userCfgFile == null && cfgFiles == null && sysCfgFileUrl == null 
>                 && (r == null || !r.exists()) && includeDefaults) {
>                 return new org.apache.cxf.bus.CXFBusFactory().createBus();
>             }
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
> {code}
>    
>    Could you please fix it?
> Cheers,
> David

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CXF-3564) SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042074#comment-13042074 ] 

Freeman Fang commented on CXF-3564:
-----------------------------------

Hi,

This actually is expected behavior in CXF 2.4, CXF Spring Bus changed a lot in cxf 2.4, the META-INF/cxf/cxf.extension already get removed. Please take a look at CXF 2.4 migration guide, more importantly, the part below

Faster startup and reduced spring configuration. The Spring support has been redone to be based on the ExtensionManagerBus. This results in much faster startup. It also means that all of the imports of META-INF/cxf/cxf-extension-*.xml are no longer needed and are deprecated.

[1]http://cxf.apache.org/docs/24-migration-guide.html

Freeman

> SpringBusFactory should read META-INF/cxf/cxf.extension during creating SpringBus
> ---------------------------------------------------------------------------------
>
>                 Key: CXF-3564
>                 URL: https://issues.apache.org/jira/browse/CXF-3564
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: David Liu
>            Assignee: Freeman Fang
>
>   It could be a bug in SpringBusFactory that it does not read META-INF/cxf/cxf.extension file which contains additional cxf extension config files. However, it uses to read META-INF/cxf/cxf.extension in 2.2.
>   Reason: In CXF 2.2, SpringBusFactory will always create BusApplicationContext to read META-INF/cxf/cxf.extension when cfgFile is null, However, CXF 2.4 does not create BusApplicationContext when cfgFile is null. I think it is a bug in CXF 2.4 because it will ignore the extions in cxf.extension file
> Code: when cfgFiles is null, SpringBusFactory will not create BusApplicationContext to read META-INF/cxf/cxf.extension file. 
> {code}
>     public Bus createBus(String cfgFiles[], boolean includeDefaults) {
>         try {
>             String userCfgFile = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_NAME);
>             String sysCfgFileUrl = System.getProperty(Configurer.USER_CFG_FILE_PROPERTY_URL);
>             Resource r = BusApplicationContext.findResource(Configurer.DEFAULT_USER_CFG_FILE);
>             if (context == null && userCfgFile == null && cfgFiles == null && sysCfgFileUrl == null 
>                 && (r == null || !r.exists()) && includeDefaults) {
>                 return new org.apache.cxf.bus.CXFBusFactory().createBus();
>             }
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
>             return finishCreatingBus(createApplicationContext(cfgFiles, includeDefaults));
> {code}
>    
>    Could you please fix it?
> Cheers,
> David

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira