[GitHub] [flink] godfreyhe commented on a change in pull request #9010: [FLINK-13114] [table-planner-blink] adapt blink planner to new unified TableEnvironment

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #9010: [FLINK-13114] [table-planner-blink] adapt blink planner to new unified TableEnvironment
URL: https://github.com/apache/flink/pull/9010#discussion_r300947453
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/operations/DataStreamQueryOperation.java
 ##########
 @@ -36,7 +36,7 @@
  * The {@link DataStreamQueryOperation#getFieldIndices()} describes the mapping between fields of the
  * {@link TableSchema} to the {@link org.apache.flink.api.common.typeutils.CompositeType}.
  */
-@Internal
+@VisibleForTesting
 
 Review comment:
   this class wraps a registered DataStream in Stream/Batch TableEnvironment before , and `registerDataStream` is a public interface method. JavaDataStreamQueryOperation & ScalaDataStreamQueryOperation was added in Java & Scala bridge module, so this class is only used for testing now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services