You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Timo Boehme (Created) (JIRA)" <ji...@apache.org> on 2012/01/23 17:15:39 UTC
[jira] [Created] (PDFBOX-1214) Allow subclassing of PDFParser
Allow subclassing of PDFParser
------------------------------
Key: PDFBOX-1214
URL: https://issues.apache.org/jira/browse/PDFBOX-1214
Project: PDFBox
Issue Type: New Feature
Components: Parsing
Affects Versions: 1.6.0
Reporter: Timo Boehme
Assignee: Timo Boehme
Priority: Minor
As a precondition of PDFBOX-1199 and other improvements implementing new ways of parsing PDF documents using existing code base it is necessary that subclasses of PDFParser can be created. While this is already possible with the current version accessing some needed methods is prohibited by the 'private' keyword. The attached patch changes this to 'protected'.
If there are no objections against the patch I will commit it in the next days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PDFBOX-1214) Allow subclassing of PDFParser
Posted by "Adam Nichols (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191720#comment-13191720 ]
Adam Nichols commented on PDFBOX-1214:
--------------------------------------
Looks fine to me
> Allow subclassing of PDFParser
> ------------------------------
>
> Key: PDFBOX-1214
> URL: https://issues.apache.org/jira/browse/PDFBOX-1214
> Project: PDFBox
> Issue Type: New Feature
> Components: Parsing
> Affects Versions: 1.6.0
> Reporter: Timo Boehme
> Assignee: Timo Boehme
> Priority: Minor
> Attachments: 2012-01-23_PDFParserProtected.patch
>
>
> As a precondition of PDFBOX-1199 and other improvements implementing new ways of parsing PDF documents using existing code base it is necessary that subclasses of PDFParser can be created. While this is already possible with the current version accessing some needed methods is prohibited by the 'private' keyword. The attached patch changes this to 'protected'.
> If there are no objections against the patch I will commit it in the next days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PDFBOX-1214) Allow subclassing of PDFParser
Posted by "Timo Boehme (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Boehme updated PDFBOX-1214:
--------------------------------
Attachment: 2012-01-23_PDFParserProtected.patch
added patch which changes some methods from 'private' to 'protected'
> Allow subclassing of PDFParser
> ------------------------------
>
> Key: PDFBOX-1214
> URL: https://issues.apache.org/jira/browse/PDFBOX-1214
> Project: PDFBox
> Issue Type: New Feature
> Components: Parsing
> Affects Versions: 1.6.0
> Reporter: Timo Boehme
> Assignee: Timo Boehme
> Priority: Minor
> Attachments: 2012-01-23_PDFParserProtected.patch
>
>
> As a precondition of PDFBOX-1199 and other improvements implementing new ways of parsing PDF documents using existing code base it is necessary that subclasses of PDFParser can be created. While this is already possible with the current version accessing some needed methods is prohibited by the 'private' keyword. The attached patch changes this to 'protected'.
> If there are no objections against the patch I will commit it in the next days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PDFBOX-1214) Allow subclassing of PDFParser
Posted by "Mel Martinez (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192161#comment-13192161 ]
Mel Martinez commented on PDFBOX-1214:
--------------------------------------
+1
I am very much in favor of this change. Thanks!
> Allow subclassing of PDFParser
> ------------------------------
>
> Key: PDFBOX-1214
> URL: https://issues.apache.org/jira/browse/PDFBOX-1214
> Project: PDFBox
> Issue Type: New Feature
> Components: Parsing
> Affects Versions: 1.6.0
> Reporter: Timo Boehme
> Assignee: Timo Boehme
> Priority: Minor
> Attachments: 2012-01-23_PDFParserProtected.patch
>
>
> As a precondition of PDFBOX-1199 and other improvements implementing new ways of parsing PDF documents using existing code base it is necessary that subclasses of PDFParser can be created. While this is already possible with the current version accessing some needed methods is prohibited by the 'private' keyword. The attached patch changes this to 'protected'.
> If there are no objections against the patch I will commit it in the next days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (PDFBOX-1214) Allow subclassing of PDFParser
Posted by "Timo Boehme (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Boehme closed PDFBOX-1214.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.7.0
fixed as proposed with svn commit r1298767
> Allow subclassing of PDFParser
> ------------------------------
>
> Key: PDFBOX-1214
> URL: https://issues.apache.org/jira/browse/PDFBOX-1214
> Project: PDFBox
> Issue Type: New Feature
> Components: Parsing
> Affects Versions: 1.6.0
> Reporter: Timo Boehme
> Assignee: Timo Boehme
> Priority: Minor
> Fix For: 1.7.0
>
> Attachments: 2012-01-23_PDFParserProtected.patch
>
>
> As a precondition of PDFBOX-1199 and other improvements implementing new ways of parsing PDF documents using existing code base it is necessary that subclasses of PDFParser can be created. While this is already possible with the current version accessing some needed methods is prohibited by the 'private' keyword. The attached patch changes this to 'protected'.
> If there are no objections against the patch I will commit it in the next days.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira