[GitHub] [trafficcontrol] mitchell852 commented on pull request #4891: TP: adds ability to perform a quick search, override default pagination size and clear column filters to servers table

[GitBox <gi...@apache.org>]

mitchell852 commented on pull request #4891:
URL: https://github.com/apache/trafficcontrol/pull/4891#issuecomment-668087100


   > I think it's weird that I can set my page size to 0, -900, etc - but also setting the page size doesn't appear to do anything:
   > ![image](https://user-images.githubusercontent.com/6013378/88437163-1e5dc500-cdc3-11ea-94db-d9f8bc9d9a2f.png)
   > 
   > Also for some reason the labels for page size and quick search (the magnifying glass) all have button-esque styling; they darken on hover, change the cursor to indicate they're click-able, and you can even click them, which looks like clicking a button. But they're actually not click-able in any meaningful sense.
   
   so `input[number]` with a min=1 won't actually prevent a user from entering a 0 or -900, for example, and wasn't really interested in adding additional code to prevent something that a user should not be / probably won't be doing. why would they enter page size=-900? and ag-grid is smart enough to ignore anything less than 1 and just use the default page size of 100. so yeah, a bit weird but not if user doesn't do weird things :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org