You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2016/03/28 09:32:42 UTC
[GitHub] tajo pull request: TAJO-2104: Implement Identifier which supports ...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/988
TAJO-2104: Implement Identifier which supports quotation information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-2104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #988
----
commit 81a31abc02796e2d8965842da0de6e9f3e7153b0
Author: Hyunsik Choi <hy...@apache.org>
Date: 2016-03-28T07:32:12Z
TAJO-2104: Implement Identifier which supports quotation information.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2104: Implement Identifier which supports ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/988#issuecomment-202339891
Thank you for the quick review. I'll commit it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2104: Implement Identifier which supports ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/988#discussion_r57553017
--- Diff: tajo-common/src/main/java/org/apache/tajo/schema/QualifiedIdentifier.java ---
@@ -0,0 +1,58 @@
+/*
+ * Lisensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.schema;
+
+import com.google.common.base.Function;
+import com.google.common.collect.ImmutableList;
+import org.apache.tajo.util.StringUtils;
+
+import javax.annotation.Nullable;
+import java.util.Collection;
+import java.util.List;
+
+import static org.apache.tajo.schema.IdentifierPolicy.DefaultPolicy;
+
+public class QualifiedIdentifier {
+ private List<Identifier> names;
+
+ private QualifiedIdentifier(ImmutableList<Identifier> names) {
+ this.names = names;
+ }
+
+ public String displayString(final IdentifierPolicy policy) {
+ return StringUtils.join(names, ".", new Function<Identifier, String>() {
--- End diff --
Looks to be IdentifierPolicy.getIdentifierSeperator() instead of ```"."```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2104: Implement Identifier which supports ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2104: Implement Identifier which supports ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/988#issuecomment-202300068
+1 LGTM!
Thanks for quick update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---