You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/25 09:39:22 UTC

[GitHub] [airflow] uranusjr commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

uranusjr commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-979031159


   Copying from Slack to record the thoughts:
   
   > My current best idea is to create a table tracking log template changes and create a fk on TaskInstance pointing to it. A row is inserted to the table when Airflow launches whenever the template does not match the last row in the table.
   
   The plan is to piggyback this operation on #18439, right after migrations are done.
   
   When a TaskInstance is created, a foreign key to this tracking table is populated to signify what log filename template this TI will use. `render_log_filename` will use this fk to render the filename, instead of accessing the config.
   
   Existing TaskInstance rows will not be backfilled for performance reasons. If this fk is NULL on TaskInstance, it will simply use the first row in the tracking table for rendering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org