You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/19 20:16:18 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #3897: Revert "Factorize common AND factors out of OR predicates to supportfilter Pu… (#3859)"

alamb opened a new pull request, #3897:
URL: https://github.com/apache/arrow-datafusion/pull/3897

   
   
   # Which issue does this PR close?
   re https://github.com/apache/arrow-datafusion/issues/3858
   
    # Rationale for this change
   I merged https://github.com/apache/arrow-datafusion/pull/3859 and I did not check it against master and it caused a logical merge conflict / plan regression
   
   
   # What changes are included in this PR?
   This reverts commit ddfd052ceef484dd36b5803dee5530a24e504893.
   
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #3897: Revert "Factorize common AND factors out of OR predicates to supportfilter Pu… (#3859)"

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3897:
URL: https://github.com/apache/arrow-datafusion/pull/3897#issuecomment-1284524361

   cc @Ted-Jiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #3897: Revert "Factorize common AND factors out of OR predicates to supportfilter Pu… (#3859)"

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3897:
URL: https://github.com/apache/arrow-datafusion/pull/3897#issuecomment-1284525985

   I ran the tests locally and they all pass for me, so I am merging this one in without waiting for CI to finish to get master back green again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #3897: Revert "Factorize common AND factors out of OR predicates to supportfilter Pu… (#3859)"

Posted by GitBox <gi...@apache.org>.
alamb merged PR #3897:
URL: https://github.com/apache/arrow-datafusion/pull/3897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org