You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Juien Enoch (JIRA)" <ji...@codehaus.org> on 2011/05/06 11:22:22 UTC

[jira] Created: (DOXIASITETOOLS-59) Using a relative path to an image in a generates a wrong "src" value for HTML tag

Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag 
----------------------------------------------------------------------------------------------------------

                 Key: DOXIASITETOOLS-59
                 URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-59
             Project: Maven Doxia Sitetools
          Issue Type: Bug
          Components: Site renderer
    Affects Versions: 1.2
            Reporter: Juien Enoch
            Priority: Minor
         Attachments: default-site.patch, site.vm

This happens only when a <bannerLeft> or <bannerRight> is also used.
Then the logo image becomes the same than the banner image.
(see attached site.xml)

This problem comes from default-site.vm in poweredByLOgo macro:
in calculation of relative path of $img code is following
     #set ( $img = $src.replaceAll( '\\', '/' ) )
But should be following
     #set ( $img = $img.replaceAll( '\\', '/' ) )
  
Please see proposed patch in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (DOXIASITETOOLS-59) Using a relative path to an image in a generates a wrong "src" value for HTML tag

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIASITETOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=265905#action_265905 ] 

Lukas Theussl commented on DOXIASITETOOLS-59:
---------------------------------------------

Funny, I just bumped into this myself today :) I'll fix it over the weekend.

> Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-59
>                 URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-59
>             Project: Maven Doxia Sitetools
>          Issue Type: Bug
>          Components: Site renderer
>    Affects Versions: 1.2
>            Reporter: Juien Enoch
>            Priority: Minor
>         Attachments: default-site.patch, site.vm
>
>
> This happens only when a <bannerLeft> or <bannerRight> is also used.
> Then the logo image becomes the same than the banner image.
> (see attached site.xml)
> This problem comes from default-site.vm in poweredByLOgo macro:
> in calculation of relative path of $img code is following
>      #set ( $img = $src.replaceAll( '\\', '/' ) )
> But should be following
>      #set ( $img = $img.replaceAll( '\\', '/' ) )
>   
> Please see proposed patch in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] (DOXIASITETOOLS-59) Using a relative path to an image in a generates a wrong "src" value for HTML tag

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/DOXIASITETOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated DOXIASITETOOLS-59:
------------------------------------------

    Fix Version/s:     (was: 1.2.1)
                   1.3
    
> Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-59
>                 URL: https://jira.codehaus.org/browse/DOXIASITETOOLS-59
>             Project: Maven Doxia Sitetools
>          Issue Type: Bug
>          Components: Site renderer
>    Affects Versions: 1.2
>            Reporter: Juien Enoch
>            Assignee: Lukas Theussl
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: default-site.patch, site.vm
>
>
> This happens only when a <bannerLeft> or <bannerRight> is also used.
> Then the logo image becomes the same than the banner image.
> (see attached site.xml)
> This problem comes from default-site.vm in poweredByLOgo macro:
> in calculation of relative path of $img code is following
>      #set ( $img = $src.replaceAll( '\\', '/' ) )
> But should be following
>      #set ( $img = $img.replaceAll( '\\', '/' ) )
>   
> Please see proposed patch in attachment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (DOXIASITETOOLS-59) Using a relative path to an image in a generates a wrong "src" value for HTML tag

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIASITETOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed DOXIASITETOOLS-59.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3
         Assignee: Lukas Theussl

Fixed in [r1100544|http://svn.apache.org/viewvc?rev=1100544&view=rev]. Thanks!

> Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-59
>                 URL: http://jira.codehaus.org/browse/DOXIASITETOOLS-59
>             Project: Maven Doxia Sitetools
>          Issue Type: Bug
>          Components: Site renderer
>    Affects Versions: 1.2
>            Reporter: Juien Enoch
>            Assignee: Lukas Theussl
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: default-site.patch, site.vm
>
>
> This happens only when a <bannerLeft> or <bannerRight> is also used.
> Then the logo image becomes the same than the banner image.
> (see attached site.xml)
> This problem comes from default-site.vm in poweredByLOgo macro:
> in calculation of relative path of $img code is following
>      #set ( $img = $src.replaceAll( '\\', '/' ) )
> But should be following
>      #set ( $img = $img.replaceAll( '\\', '/' ) )
>   
> Please see proposed patch in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira