[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19033: Numpy RNN operator large dim checks

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #19033:
URL: https://github.com/apache/incubator-mxnet/pull/19033#discussion_r480296732



##########
File path: src/operator/rnn.cc
##########
@@ -69,6 +69,10 @@ static bool RNNShape(const nnvm::NodeAttrs& attrs,
   CHECK_EQ(dshape.ndim(), 3U) \
       << "Input data should be rank-3 tensor of dim [sequence length, batch size, input size]";
   // data: [sequence len, batch, input dimension]
+  for (int i = 0; i < dshape.ndim(); i++) {
+    CHECK_LT(dshape[i], INT32_MAX) << "ValueError: RNN does not support large"

Review comment:
       can you also point out which dimension gives error. This will be helpful for users to understand where they need to do correction




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org