You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/05/07 13:59:09 UTC
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22864
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/calcite/tpcds-q99.test
113 files changed, 131,862 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@146
PS1, Line 146: tpcds_cpu_cost/calcite/tpcds-q01
I'd suggest putting the .test file dir right under testdata/workloads/functional-planner/queries/PlannerTest/ for easier diff.
So maybe like:
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 00:09:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19145/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 14:45:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4:
(2 comments)
Is this something that should run as part of precommit? If so, we can add the test command to bin/run-all-tests.sh under the FE_TEST section.
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@18
PS4, Line 18: package org.apache.impala.planner;
Two things here:
1. We should have the package and directory structure line up. If something is in org.apache.impala.planner, it belongs in org/apache/impala/planner. IDEs complain about this.
2. I think it makes sense for the test code to be in org.apache.impala.calcite, since this maven project has all its code in that package. We don't want two different org.apache.impala.planner.TpcdsCpuCostPlannerTest classes to exist in Impala.
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@105
PS4, Line 105: //setupAdmissionControl();
One of the differences from the regular TpcdsCpuCostPlannerTest is that we don't setup admission control. Is it that we don't need it because we aren't testing memory limits?
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 May 2025 22:27:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57
PS7, Line 57: // Pool definitions and includes memory resource limits, copied to a temporary file
: private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml";
:
: // Contains per-pool configurations for maximum number of running queries and queued
: // requests.
: private static final String LLAMA_CONFIG_FILE = "llama-site-3-groups.xml";
> nit: maybe also comment that these are copied from ./fe/src/test/resources/
Your comment here kinda showed me how I really needed to do some due diligence on how to make sure it grabs from the same place.
Did the research, and I changed the pom file. It will now always grab resources from fe/src/test/resources. I don't think this is really a bad thing, though I'm willing to change it if someone disagrees.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 13:49:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Reviewed-on: http://gerrit.cloudera.org:8080/22864
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Riza Suminto <ri...@cloudera.com>
---
M bin/run-all-tests.sh
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
114 files changed, 131,906 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Riza Suminto: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 14
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10:
I will rebase and DRY_RUN this patch.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 19:56:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 7:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19301/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 May 2025 17:41:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9: Code-Review+1
This is looking good to me. Are we intending to run these tests as part of precommit?
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 May 2025 17:46:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4:
set use_calcite_planner=1;
select casttobigint(100000);
+------------------------------------------------------------------------------------------------------------------------------+
| AnalyzedFunctionCallExpr{id=null, type=BIGINT, toSql=casttobigint(CAST(100000 AS INT)), sel=-1.0, evalCost=1.0, #distinct=1} |
+------------------------------------------------------------------------------------------------------------------------------+
| 100000 |
+------------------------------------------------------------------------------------------------------------------------------+
Fetched 1 row(s) in 0.11s
set use_calcite_planner=0;
select casttobigint(100000);
ERROR: AnalysisException: casttobigint(100000) is reserved for internal use only. Use 'cast(expr AS type)' instead.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 May 2025 10:54:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 3:
Fyi: These plans are inefficient, as you might already know. I needed a base to show that every new performance commit changes the plan.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:50:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9:
> This is looking good to me. Are we intending to run these tests as
> part of precommit?
> This is looking good to me. Are we intending to run these tests as
> part of precommit?
To run it in precommit, we would need to run these tests in bin/run-all-tests.sh, probably as part of the FE_TEST section.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 May 2025 17:54:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10: Code-Review+1
FE tests is running here: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5571/
Once it pass, I can help DRY_RUN this patch.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 18:17:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#10).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M bin/run-all-tests.sh
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
114 files changed, 131,906 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/10
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11951/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 19:58:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19299/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 May 2025 17:36:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
LGTM. Carry forward Riza and Joe's votes and adding mine.
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@69
PS9, Line 69: private static TQueryOptions options =
> There is no fallback logic right now for Calcite, so the tests will fail.
Done
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@70
PS9, Line 70: tpcdsParquetQueryOptions()
> Filed IMPALA-14113
Done
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 16:21:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 11:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11952/
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 10:10:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jun 2025 00:23:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11963/
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 18:10:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#2).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
113 files changed, 131,862 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/2
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11851/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 13:59:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10: Code-Review+2
That test run passed and I see the calcite tests listed in the Test Results here: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5571/testReport/org.apache.impala.calcite.planner/TpcdsCpuCostPlannerTest/
So, this looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 19:20:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jun 2025 00:25:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11952/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 04:06:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19306/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 15:01:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 8:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19305/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 14:37:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@69
PS9, Line 69: private static TQueryOptions options =
With these options, in case the tpcd-ds query encounters an exception in the Calcite planning, will the query fail for sure or would it attempt fall back ? We want to make sure it fails.
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@70
PS9, Line 70: tpcdsParquetQueryOptions()
In the future, can we enhance the junit test to also product the Calcite specific CBO plan that can be tracked ?
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 May 2025 18:26:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 3: Code-Review+1
As long as the test run consistent, it should be good to merge.
We can iterate after this if we notice some inefficient Calcite plan.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:34:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@18
PS4, Line 18: package org.apache.impala.planner;
> Two things here:
Done
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@105
PS4, Line 105: //setupAdmissionControl();
> One of the differences from the regular TpcdsCpuCostPlannerTest is that we
I just overlooked this on my first pass because I wanted to simplify things to get them to work.
Latest patch now uses this.
I did copy over the resource files rather than try to reuse them. Are you ok with this? It was easier to just make a new copy and I think it might make sense anyway, but I can reuse if you think it's better.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 May 2025 17:18:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11960/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sun, 01 Jun 2025 23:55:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 12:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11960/
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 06:10:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#12).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M bin/run-all-tests.sh
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
114 files changed, 131,906 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/12
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@69
PS9, Line 69: private static TQueryOptions options =
> With these options, in case the tpcd-ds query encounters an exception in th
There is no fallback logic right now for Calcite, so the tests will fail. Even if we do add fallback logic, the explain plans will wind up being way different, so tests should fail anyway.
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@70
PS9, Line 70: tpcdsParquetQueryOptions()
> In the future, can we enhance the junit test to also product the Calcite sp
Filed IMPALA-14113
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 16:09:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11866/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 13:20:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19351/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 15:05:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#7).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A java/calcite-planner/src/test/resources/fair-scheduler-3-groups.xml
A java/calcite-planner/src/test/resources/llama-site-3-groups.xml
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
115 files changed, 131,982 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/7
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57
PS7, Line 57: // Pool definitions and includes memory resource limits, copied to a temporary file
: private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml";
:
: // Contains per-pool configurations for maximum number of running queries and queued
: // requests.
: private static final String LLAMA_CONFIG_FILE = "llama-site-3-groups.xml";
> Is java/calcite-planner/src/test/resources/fair-scheduler-3-groups.xml and
Whoops, coulda sworn I removed them.
Done.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 14:33:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10:
Added running the java/calcite_planner junit tests in the run-all-tests.sh file
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 17:00:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19138/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 14:27:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19144/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 14:43:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11951/
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 02:09:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11964/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 18:21:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 May 2025 15:40:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#3).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
113 files changed, 131,863 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/3
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22864/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22864/1//COMMIT_MSG@8
PS1, Line 8:
: This commit will enable some junit tests for the Calcite planner.
> In commit message, can you say how to run just this planner test from $IMPA
Done
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@146
PS1, Line 146: tpcds_cpu_cost/calcite/tpcds-q01
> I'd suggest putting the .test file dir right under testdata/workloads/funct
Done
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 14:19:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#9).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
113 files changed, 131,899 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/9
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 17:25:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 10: Code-Review+2
Thank you for enabling the test!
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 17:01:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11963/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 12:08:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 6:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19300/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 May 2025 17:35:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#6).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
113 files changed, 131,893 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/6
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 13: Code-Review+2
Carry Joe's +2.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jun 2025 00:27:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 20:12:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9:
> Patch Set 9:
>
> To run it in precommit, we would need to run these tests in bin/run-all-tests.sh, probably as part of the FE_TEST section.
This has not been answered. I think it is easy to hook it to run-all-test.sh (search for "Run JUnit frontend tests"), but I also don't mind to not run it yet until the testcases are stable.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 May 2025 16:25:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#5).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
113 files changed, 131,893 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/5
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@105
PS4, Line 105:
> I just overlooked this on my first pass because I wanted to simplify things
Memory bounding looks good after proper admission control setup.
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57
PS7, Line 57: // Pool definitions and includes memory resource limits, copied to a temporary file
: private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml";
:
: // Contains per-pool configurations for maximum number of running queries and queued
: // requests.
: private static final String LLAMA_CONFIG_FILE = "llama-site-3-groups.xml";
nit: maybe also comment that these are copied from ./fe/src/test/resources/fair-scheduler-3-groups.xml and ./fe/src/test/resources/llama-site-3-groups.xml accordingly. So we remember to update one, when the other changed.
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 04:00:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57
PS7, Line 57: public class TpcdsCpuCostPlannerTest extends PlannerTestBase {
: // Pool definitions and includes memory resource limits, copied to a temporary file
: private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml";
:
: // Contains per-pool configurations for maximum number of running queries and queued
: // requests.
> Your comment here kinda showed me how I really needed to do some due dilige
Is java/calcite-planner/src/test/resources/fair-scheduler-3-groups.xml and java/calcite-planner/src/test/resources/llama-site-3-groups.xml can be removed then?
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 14:13:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57
PS9, Line 57: public class TpcdsCpuCostPlannerTest extends PlannerTestBase {
: // Pool definitions and includes memory resource limits, copied to a temporary file
: private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml";
:
: // Contains per-pool configurations for maximum number of running queries and queued
: // requests.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 May 2025 14:37:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Anonymous Coward (816), Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22864
to look at the new patch set (#8).
Change subject: IMPALA-14041: Enable planner tests
......................................................................
IMPALA-14041: Enable planner tests
This commit will enable some junit tests for the Calcite planner.
To run these tests, use the following command from $IMPALA_HOME:
(pushd java/calcite-planner && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
---
M java/calcite-planner/pom.xml
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java
A java/calcite-planner/src/test/resources/fair-scheduler-3-groups.xml
A java/calcite-planner/src/test/resources/llama-site-3-groups.xml
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q01.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q03.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q04.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q05.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q06.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q07.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q09.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q10a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q11.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q12.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q13.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q15.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q16.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q17.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q18.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q19.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q20.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q21.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q22.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q25.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q26.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q27.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q28.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q29.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q30.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q31.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q32.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q34.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q35a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q36.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q37.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q38.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39a.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q39b.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q40.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q41.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q42.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q45.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q46.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q47.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q48.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q50.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q51.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q52.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q53.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q55.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q57.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q58.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q59.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q62.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q63.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q64.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q65.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q66.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q67.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q68.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q69.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q70.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q71.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q72.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q73.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q74.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q75.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q76.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q77.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q78.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q79.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q80.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q81.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q82.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q83.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q84.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q85.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q86.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q87.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q88.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q90.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q92.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q93.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q94.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q95.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q96.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit-10g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97-mem_limit_executors-20g.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q97.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q98.test
A testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q99.test
115 files changed, 131,988 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/22864/8
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java
File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/22864/1/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@673
PS1, Line 673: runPlannerTestFile("tpcds_cpu_cost/calcite/tpcds-q43-verbose", testDb, options, testOptions);
line too long (97 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 14:00:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22864/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22864/1//COMMIT_MSG@8
PS1, Line 8:
: This commit will enable some junit tests for the Calcite planner.
In commit message, can you say how to run just this planner test from $IMPALA_HOME?
This is how I do it for existing Impala planner test.
(pushd fe && mvn -B -fae test -Dtest=TpcdsCpuCostPlannerTest)
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 00:14:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14041: Enable planner tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf
Gerrit-Change-Number: 22864
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 19:33:05 +0000
Gerrit-HasComments: No