You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/10/09 15:09:00 UTC
[jira] [Commented] (ARTEMIS-5099) Probable impossible cast in AMQPLargeMessage
[ https://issues.apache.org/jira/browse/ARTEMIS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028797#comment-18028797 ]
ASF subversion and git services commented on ARTEMIS-5099:
----------------------------------------------------------
Commit 8ad0038fc0a045f4b275939f253aa8154683afde in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8ad0038fc0 ]
ARTEMIS-5099 fix impossible cast in AMQPLargeMessage
I believe this was likely a copy-and-paste error involving
o.a.a.a.c.p.i.j.LargeServerMessageImpl#referenceOriginalMessage.
> Probable impossible cast in AMQPLargeMessage
> --------------------------------------------
>
> Key: ARTEMIS-5099
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5099
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Andrey Slepykh
> Assignee: Justin Bertram
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There is an impossible cast from {{LargeServerMessageImpl}} to {{AMQPLargeMessage}} in [https://github.com/apache/activemq-artemis/blob/4c6cded2e79cf10d2323de1b5fa7418b289ab034/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java#L638]
> I suppose there is a mistake in the check above ([here|https://github.com/apache/activemq-artemis/blob/4c6cded2e79cf10d2323de1b5fa7418b289ab034/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java#L637]) and original should be instance of {{AMQPLargeMessage}}, but not {{LargeServerMessageImpl}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact