You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/04 09:54:11 UTC
[GitHub] [kafka] vamossagar12 opened a new pull request #10051: Adding documentation for KIP-614
vamossagar12 opened a new pull request #10051:
URL: https://github.com/apache/kafka/pull/10051
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773415951
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-785321000
Fixed the merge conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909411
@vamossagar12, you need to rebase your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#discussion_r570139416
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -154,6 +154,14 @@ <h3><a id="streams_api_changes_270" href="#streams_api_changes_270">Streams API
turn on all higher levels, ie INFO and DEBUG. See <a href="https://cwiki.apache.org/confluence/x/gBkRCQ">KIP-613</a> for more information.
</p>
+ <p>
+ We added <code>prefixScan</code> API to <code>ReadOnlyKeyValueStore</code>. This would allow scanning the state store to fetch all
+ keys starting with the prefix supplied as an argument. Since the type of the key can be different from that of the key, this API also
+ takes a serializer as an argument to convert the prefix into the format in which the keys have been stored in the state store. See
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores">KIP-614</a> for
+ more details.
Review comment:
You need to move this paragraph to line 124 since it will be released with 2.8 and NOT with 2.7.
I also have some suggestions:
```suggestion
We added method <code>prefixScan()</code> to interface <code>ReadOnlyKeyValueStore</code>.
Method <code>prefixScan()</code> allows fetching all values whose keys start with a given prefix.
See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores">KIP-614</a> for more details.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773943202
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 edited a comment on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vamossagar12 edited a comment on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773943202
@cadonna Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#discussion_r570139416
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -154,6 +154,14 @@ <h3><a id="streams_api_changes_270" href="#streams_api_changes_270">Streams API
turn on all higher levels, ie INFO and DEBUG. See <a href="https://cwiki.apache.org/confluence/x/gBkRCQ">KIP-613</a> for more information.
</p>
+ <p>
+ We added <code>prefixScan</code> API to <code>ReadOnlyKeyValueStore</code>. This would allow scanning the state store to fetch all
+ keys starting with the prefix supplied as an argument. Since the type of the key can be different from that of the key, this API also
+ takes a serializer as an argument to convert the prefix into the format in which the keys have been stored in the state store. See
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores">KIP-614</a> for
+ more details.
Review comment:
You need to move this paragraph to line 124 since it will be released with 2.8 and NOT with 2.7.
I also have some suggestions:
```suggestion
We added method <code>prefixScan()</code> to interface <code>ReadOnlyKeyValueStore</code>.
Method <code>prefixScan()</code> allows fetching all values whose keys start with a given prefix.
See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores">KIP-614</a> for more details.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773415951
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #10051:
URL: https://github.com/apache/kafka/pull/10051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909549
Call for committer review: @guozhangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10051: Adding documentation for KIP-614
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10051:
URL: https://github.com/apache/kafka/pull/10051#issuecomment-785322634
Merged to 2.8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org