You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/25 18:26:22 UTC
[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions, and comparison operators / matchers for SV data types
nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r929176335
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 && functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
Count(*) has no operands. Since I allow now count(colName), I removed the if in lines 84-88 and add this if here instead.
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 && functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
`Count(*)` has no operands. Since I allow now `count(colName)`, I removed the if in lines 84-88 and add this if here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org