You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "anukalp2804 (via GitHub)" <gi...@apache.org> on 2026/03/08 16:28:52 UTC
[PR] Fix the duplicate literals using the constant [iotdb]
anukalp2804 opened a new pull request, #17274:
URL: https://github.com/apache/iotdb/pull/17274
## Description
This PR fixes duplicate literals reported by the sonarcloud analysis tool.These changes ensure the code follows the project's formatting guidelines.
Changes:
- replace the duplicate literals with constant
## Files modified:
- `example/jdbc/src/main/java/org/apache/iotdb/TableModelJDBCExample.java`.
- `example/session/src/main/java/org/apache/iotdb/TableModelSessionExample.java`.
- `example/session/src/main/java/org/apache/iotdb/TableModelSessionPoolExample.java`.
This change addresses a Sonar-reported duplicate literals for the show tables:
- https://sonarcloud.io/project/issues?open=AZE17wkw7_EafdyqQKly&id=apache_iotdb
- https://sonarcloud.io/project/issues?open=AZE17wi77_EafdyqQKlE&id=apache_iotdb
- https://sonarcloud.io/project/issues?open=AZE17wkE7_EafdyqQKlf&id=apache_iotdb
This PR has:
- [x] been self-reviewed.
- [x] been built locally with `mvn spotless:apply`.
- [x] been built locally with `mvn clean package -DskipTests`.
- [x] been built locally with `mvn -pl iotdb-core -am test -DskipTests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the duplicate literals using the constant [iotdb]
Posted by "anukalp2804 (via GitHub)" <gi...@apache.org>.
anukalp2804 commented on PR #17274:
URL: https://github.com/apache/iotdb/pull/17274#issuecomment-4041278540
> LGTM
Thank you for the review and approval!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the duplicate literals using the constant [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #17274:
URL: https://github.com/apache/iotdb/pull/17274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org