You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/26 16:09:44 UTC

[GitHub] [bookkeeper] WJL3333 opened a new issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

WJL3333 opened a new issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421


   in this line just set basePath use ledgerDirsManager which only manage one dir
   https://github.com/apache/bookkeeper/blob/2c3d8f55895890e73b58a43e337f7ff9ac140675/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java#L143
   
   and just use variable basePath to initialize ledgerDirsManager and LedgerMetadataIndex
   https://github.com/apache/bookkeeper/blob/2c3d8f55895890e73b58a43e337f7ff9ac140675/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java#L162
   
   the indexDirectories is not use at all.
   
   does this means indexDirectories will be ignored when use DbLedgerStorage ？
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421#issuecomment-699759672


   @jiazhai thanks for reply. is there an plan to use this config? i wonder if rocksdb for index and entrylogger on the same disk 
   harm the performance. if this is just ok. maybe i can fix the document.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421#issuecomment-699792894


   I can't remember this request in the past.
   We should definitely take care of this.
   
   It will be necessary to handle backward compatibility, that is to let bookies that have RocksDB on the current folder work


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] jiazhai commented on issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421#issuecomment-699730673


   @WJL3333 right. indexDirectories will be ignored when use DbLedgerStorage .  indexDirectories is used in other type of ledgerstorage, such as interlivedLedgerStorage


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 edited a comment on issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

Posted by GitBox <gi...@apache.org>.
WJL3333 edited a comment on issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421#issuecomment-699759672


   @jiazhai thanks for reply. is there any plan to use this config? i wonder if rocksdb for index and entrylogger on the same disk 
   harm the performance. if this is just ok. maybe i can fix the document.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2421: Why DbLedgerStorage doesn't use indexDirectories to store index ？

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2421:
URL: https://github.com/apache/bookkeeper/issues/2421#issuecomment-700530540


   @eolivelli thanks for reply. it seems a lot to take care. i need take a deep look inside.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org