You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/06/28 00:44:48 UTC

Review Request 12143: Template created from snapshot: the vmdk path needs to be modified to accomodate the changed snapshot UUID format.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12143/
-----------------------------------------------------------

Review request for cloudstack and edison su.


Bugs: CLOUDSTACK-2384


Repository: cloudstack-git


Description
-------

In DB, and backedUpSnapshotUuid has the format of uuid/uuid. change the vmdk file path to the correct one.


Diffs
-----

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 4ae0f30 

Diff: https://reviews.apache.org/r/12143/diff/


Testing
-------

Create a new snapshot from a vol; 
Create a template from this volume. With the bug, this operation failed with error of failing to copy the vmdk files.
After the fix, all the files are created in template dir:
e.g., under template/tmpl/2/209:
[root@nfs2 209]# ls -lt
total 410724
-rw-r--r-- 1 root root 420134912 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15-disk0.vmdk
-rw-r--r-- 1 root root       239 Jun 27 14:19 d2d4d8f2-2916-4034-8053-3ed011d1be6e.ova.meta
-rw-r--r-- 1 root root       299 Jun 27 14:19 template.properties
-rw-r--r-- 1 root root      3839 Jun 27 14:19 585fcc4b-a00b-4dc3-a03b-cab09c41cd15.ovf


Thanks,

Fang Wang