You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/03/26 03:11:03 UTC

[GitHub] [incubator-datasketches-website] leerho opened a new pull request #84: More refactor

leerho opened a new pull request #84: More refactor
URL: https://github.com/apache/incubator-datasketches-website/pull/84
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org

[GitHub] [incubator-datasketches-website] jmalkin commented on a change in pull request #84: More refactor

Posted by GitBox <gi...@apache.org>.

jmalkin commented on a change in pull request #84: More refactor
URL: https://github.com/apache/incubator-datasketches-website/pull/84#discussion_r398700137

##########
File path: docs/Community/Downloads.md
##########
@@ -32,11 +32,13 @@ It is essential that you verify the integrity of release downloads. See [instruc
From [Maven Central](https://search.maven.org/search?q=g:%20org.apache.datasketches).

## Version Numbers
-Apache DataSketches uses [semantic versioning](https://semver.org/). Version numbers use the form major.minor.incremental and are incremented as follows:
+Apache DataSketches uses [semantic versioning](https://semver.org/). Version numbers use the form major.minor.incremental and are updated as follows:

-* __major version__ for major new functionality and/or major API changes that may be incompatible with prior versions
-* __minor version__ for new functionality and scheduled bug fixes. This should be API compatible with prior versions
-* __incremental version__ for unscheduled bug fixes only
+* __major version__ for major new functionality and/or major API changes that may (or may not) be API compatible with prior versions.
+* __minor version__ for new functionality and scheduled bug fixes. These should be API compatible with prior versions.
+* __incremental version__ for unscheduled bug fixes only.
+
+Note: we maintain *binary compatiblity* of a specific sketch type across language and time, independent of releases. For example, a Theta Sketch version 0.1.0 (Aug, 2015) generated using Java and stored to its binary image can be merged with a Theta Sketch version 1.2.0 (Jan, 2020) generated with C++ and stored to its binary image.

Review comment:
It's specifically forward-compatibilit, no? The newer versions can read the older versions, not the other way around.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org

[GitHub] [incubator-datasketches-website] leerho commented on issue #84: More refactor

Posted by GitBox <gi...@apache.org>.

leerho commented on issue #84: More refactor
URL: https://github.com/apache/incubator-datasketches-website/pull/84#issuecomment-604204180
 
 
   This is rearranging the ToC as well as the locations of md files to make them easier to find when looking at the directories.  I also added some md files that were missing from the ToC.  I added bullets to the doc files under the ToC headings because when the length of the doc description wrapped to the next line one could not distinguish one list element from the next.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org

[GitHub] [incubator-datasketches-website] leerho merged pull request #84: More refactor

Posted by GitBox <gi...@apache.org>.

leerho merged pull request #84: More refactor
URL: https://github.com/apache/incubator-datasketches-website/pull/84
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org

[GitHub] [incubator-datasketches-website] jmalkin commented on a change in pull request #84: More refactor

Posted by GitBox <gi...@apache.org>.

jmalkin commented on a change in pull request #84: More refactor
URL: https://github.com/apache/incubator-datasketches-website/pull/84#discussion_r398699149

Review comment:
For a version bump, users should expect there to be some API-incompatible changes. I think this language makes it too soft.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org