You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/29 20:40:57 UTC
[GitHub] [superset] Paulo-Eduardo opened a new pull request, #21243: fix(): Copy icon is out of box when resize query modal
Paulo-Eduardo opened a new pull request, #21243:
URL: https://github.com/apache/superset/pull/21243
### SUMMARY
Adding a fail safe to get default resize config when receive an empty object.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
https://user-images.githubusercontent.com/29920585/187294675-11e487cd-a0e9-4765-b7d0-85cb0b390e44.mov
AFTER
https://user-images.githubusercontent.com/29920585/187294701-2326cd95-b7be-4978-b899-1198cb03729a.mov
### TESTING INSTRUCTIONS
- open a chart in explore, click on ... menu in the top right and select 'View query'
- Minimize the view query window and observe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Paulo-Eduardo commented on a diff in pull request #21243: fix(ViewQuery-Modal): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
Paulo-Eduardo commented on code in PR #21243:
URL: https://github.com/apache/superset/pull/21243#discussion_r958721741
##########
superset-frontend/src/components/Modal/Modal.tsx:
##########
@@ -289,6 +290,13 @@ const CustomModal = ({
}
};
+ const getResizableConfig = () => {
Review Comment:
OHH, THAT IS RIGHT! Thank you 😊 working on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21243: fix(): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21243:
URL: https://github.com/apache/superset/pull/21243#issuecomment-1230883739
# [Codecov](https://codecov.io/gh/apache/superset/pull/21243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21243](https://codecov.io/gh/apache/superset/pull/21243?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce6ec83) into [master](https://codecov.io/gh/apache/superset/commit/8772e2cdb3b5a500812e7df12c133f9c9f2e6bad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8772e2c) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21243 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1784 1784
Lines 68163 68168 +5
Branches 7264 7265 +1
=======================================
+ Hits 45285 45290 +5
Misses 21010 21010
Partials 1868 1868
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.50% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/21243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `89.18% <100.00%> (+0.78%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #21243: fix(): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #21243:
URL: https://github.com/apache/superset/pull/21243#issuecomment-1230872471
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21243: fix(ViewQuery-Modal): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21243:
URL: https://github.com/apache/superset/pull/21243#issuecomment-1236062273
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #21243: fix(ViewQuery-Modal): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #21243:
URL: https://github.com/apache/superset/pull/21243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21243: fix(): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21243:
URL: https://github.com/apache/superset/pull/21243#issuecomment-1230874158
@yousoph Ephemeral environment spinning up at http://35.89.85.65:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on a diff in pull request #21243: fix(ViewQuery-Modal): Copy icon is out of box when resize query modal
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on code in PR #21243:
URL: https://github.com/apache/superset/pull/21243#discussion_r958078903
##########
superset-frontend/src/components/Modal/Modal.tsx:
##########
@@ -289,6 +290,13 @@ const CustomModal = ({
}
};
+ const getResizableConfig = () => {
Review Comment:
It would be nice if we can use `useMemo` to reduce called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org