You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2016/03/29 19:55:59 UTC
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1276
STORM-1664: Allow Java users to start a local cluster with a Nimbus T…
…hrift server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-1664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1276
----
commit 045b507dc7d97b42fcccbb405f236113e62a2434
Author: Stig Døssing <sd...@it-minds.dk>
Date: 2016-03-29T16:58:45Z
STORM-1664: Allow Java users to start a local cluster with a Nimbus Thrift server
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1276#discussion_r57956028
--- Diff: storm-core/src/clj/org/apache/storm/testing4j.clj ---
@@ -79,10 +79,12 @@
[cluster-type mkClusterParam code]
`(let [supervisors# (or (.getSupervisors ~mkClusterParam) 2)
ports-per-supervisor# (or (.getPortsPerSupervisor ~mkClusterParam) 3)
- daemon-conf# (or (.getDaemonConf ~mkClusterParam) {})]
+ daemon-conf# (or (.getDaemonConf ~mkClusterParam) {})
+ nimbus-daemon# (or (.isNimbusDaemon ~mkClusterParam) false)]
--- End diff --
Right, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1276: STORM-1664: Allow Java users to start a local clus...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1276: STORM-1664: Allow Java users to start a local cluster wit...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1276
@knusbaum Mind merging if you're still +1 on this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1276#discussion_r57953984
--- Diff: storm-core/src/clj/org/apache/storm/testing4j.clj ---
@@ -79,10 +79,12 @@
[cluster-type mkClusterParam code]
`(let [supervisors# (or (.getSupervisors ~mkClusterParam) 2)
ports-per-supervisor# (or (.getPortsPerSupervisor ~mkClusterParam) 3)
- daemon-conf# (or (.getDaemonConf ~mkClusterParam) {})]
+ daemon-conf# (or (.getDaemonConf ~mkClusterParam) {})
+ nimbus-daemon# (or (.isNimbusDaemon ~mkClusterParam) false)]
--- End diff --
The `or` here is unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1276: STORM-1664: Allow Java users to start a local cluster wit...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1276
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1276#issuecomment-203615052
+1 pending Travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1276#issuecomment-203608785
Hi, yes it's useful for running https://github.com/roshannaik/storm-benchmark-sol in local mode, since that code uses NimbusClient for pulling throughput metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1664: Allow Java users to start a local ...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1276#issuecomment-203605221
Is there a reason for wanting this? I see you've made the change but no code is using it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---