You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/02/15 15:56:47 UTC

Review Request 31061: AMS : Hosts metrics - "mem_shared" metrics array contains "null"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31061/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-9652
    https://issues.apache.org/jira/browse/AMBARI-9652


Repository: ambari


Description
-------

API Call : 
http://hostname1:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal?fields=metrics/memory/swap_free[1419885754,1419889354,15],metrics/memory/mem_shared[1419885754,1419889354,15],metrics/memory/mem_free[1419885754,1419889354,15],metrics/memory/mem_cached[1419885754,1419889354,15],metrics/memory/mem_buffers[1419885754,1419889354,15]
Check "mem_shared" in response of the above api.


Diffs
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 68b4be8 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMapTest.java PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java 8cff741 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/YarnAMSJacksonJaxbJsonProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 843aecd 
  ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 

Diff: https://reviews.apache.org/r/31061/diff/


Testing
-------

[INFO] ambari-metrics .................................... SUCCESS [0.612s]
[INFO] ambari-metrics-common ............................. SUCCESS [1.948s]
[INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.216s]
[INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.367s]
[INFO] ambari-metrics-kafka-sink ......................... SUCCESS [1.501s]
[INFO] ambari-metrics-storm-sink ......................... SUCCESS [1.715s]
[INFO] ambari-metrics-timelineservice .................... SUCCESS [36.395s]
[INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.698s]
[INFO] ambari-metrics-assembly ........................... SUCCESS [2:12.992s]
[INFO] ------------------------------------------------------------------------


Thanks,

Dmytro Sen


Re: Review Request 31061: AMS : Hosts metrics - "mem_shared" metrics array contains "null"

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31061/#review72544
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Лют. 15, 2015, 4:56 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31061/
> -----------------------------------------------------------
> 
> (Updated Лют. 15, 2015, 4:56 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-9652
>     https://issues.apache.org/jira/browse/AMBARI-9652
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API Call : 
> http://hostname1:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal?fields=metrics/memory/swap_free[1419885754,1419889354,15],metrics/memory/mem_shared[1419885754,1419889354,15],metrics/memory/mem_free[1419885754,1419889354,15],metrics/memory/mem_cached[1419885754,1419889354,15],metrics/memory/mem_buffers[1419885754,1419889354,15]
> Check "mem_shared" in response of the above api.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 68b4be8 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMapTest.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java 8cff741 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/YarnAMSJacksonJaxbJsonProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 843aecd 
>   ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31061/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ambari-metrics .................................... SUCCESS [0.612s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.948s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.216s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.367s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [1.501s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [1.715s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [36.395s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.698s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [2:12.992s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 31061: AMS : Hosts metrics - "mem_shared" metrics array contains "null"

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31061/#review72543
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Feb. 15, 2015, 2:56 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31061/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 2:56 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-9652
>     https://issues.apache.org/jira/browse/AMBARI-9652
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API Call : 
> http://hostname1:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal?fields=metrics/memory/swap_free[1419885754,1419889354,15],metrics/memory/mem_shared[1419885754,1419889354,15],metrics/memory/mem_free[1419885754,1419889354,15],metrics/memory/mem_cached[1419885754,1419889354,15],metrics/memory/mem_buffers[1419885754,1419889354,15]
> Check "mem_shared" in response of the above api.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 68b4be8 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMapTest.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AHSWebApp.java 8cff741 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/YarnAMSJacksonJaxbJsonProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java 843aecd 
>   ambari-server/src/main/java/org/apache/hadoop/metrics2/sink/timeline/deserialize/IgnoringNullsLinkedHashMap.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31061/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ambari-metrics .................................... SUCCESS [0.612s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.948s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.216s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.367s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [1.501s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [1.715s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [36.395s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.698s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [2:12.992s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>