[GitHub] [incubator-pinot] mcvsubbu commented on issue #4825: Bug Fix: Fix segment download url in SegmentZkMetadata.

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #4825: Bug Fix: Fix segment download url in SegmentZkMetadata.
URL: https://github.com/apache/incubator-pinot/pull/4825#issuecomment-554022371
 
 
   > Will this break the case in which we have a special character in the segment in local FS? You may want to run at least a manual test with special character, and make sure that it works right on the download side as well.
   > The correct fix may be to check if it is local file system, or introduce APIs in PinotFS to generate the right URI (so, a local FS can do the right thing of not encoding special characters with %xx)
   
   @mayankshriv thanks for pointing out that the if statement before covers the local file system. My comment does not hold in that case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org