[GitHub] [tinkerpop] jorgebay opened pull request #1209: TINKERPOP-2305 GraphBinary: Buffer API

["jorgebay (GitHub)" <gi...@apache.org>]

https://issues.apache.org/jira/browse/TINKERPOP-2305

Introduce our own `Buffer` interface as a wrapper of Netty's `ByteBuf`, allowing us to move GraphBinary serialization to `gremlin-core`.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1209 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

["jorgebay (GitHub)" <gi...@apache.org>]

In most cases, writing to and reading from `Buffer` using built in methods will be enough. In cases where providers need to read and write directly to Netty buffers, I've exposed a couple of utility methods that allow access to the raw memory block under `Buffer` instances using Netty: `NettyBufferFactory.readRaw()` and `NettyBufferFactory.writeRaw()`.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1209 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

["jorgebay (GitHub)" <gi...@apache.org>]

I'll add a couple of utility methods to access the underlying memory of `Buffer` for providers to use if needed.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1209 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1209: TINKERPOP-2305 GraphBinary: Buffer API

["jorgebay (GitHub)" <gi...@apache.org>]

Good catch about `gremlin-io-test`!

I've fixed it and declared parameters `final` in the public API.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1209 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org