You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Csaba Ringhofer (JIRA)" <ji...@apache.org> on 2018/09/11 12:16:00 UTC
[jira] [Work stopped] (IMPALA-7359) Make local timezone
deterministic during tests
[ https://issues.apache.org/jira/browse/IMPALA-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on IMPALA-7359 stopped by Csaba Ringhofer.
-----------------------------------------------
> Make local timezone deterministic during tests
> ----------------------------------------------
>
> Key: IMPALA-7359
> URL: https://issues.apache.org/jira/browse/IMPALA-7359
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Major
>
> Currently Impala uses the timezone of the machine where impalad runs for local<-> utc time conversions. This makes it hard to test these functions, as they give different results depending on the location. Some tests solve this by starting a custom cluster after setting env var TZ, while others do not check the results precisely (only check that local!=utc, which is not true in some region).
> I would prefer to avoid starting custom clusters for these tests, because doing that makes the tests significantly slower.
> I see 3 possible solutions (easiest to hardest):
> - Start the minicluster with a specific timezone by default (e.g America/Los_Angeles). This could surprise people a bit, but wouldn't cause real issues as the minicluster is not meant for production. The simplest way to do this is setting env var TZ, but this could have some unintended side effects if other parts of the program use TZ too (e.g. logging).
> - Do the same but use a new startup flag instead of TZ. It would be possible to ensure that there are no side effects this way.
> - Add a query option to set local time. HIVE has a similar feature, see HIVE-16614.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org