[jira] [Comment Edited] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

["Vincent Poon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661762#comment-16661762 ] 

Vincent Poon edited comment on PHOENIX-4990 at 10/24/18 6:00 AM:
-----------------------------------------------------------------

[~gjacoby] The check immediately after await() is checking the executor for # of active threads, not the numAttempts counter.
Runner.stop() is called next and should wait for the thread to finish (after an interrupt).  If the thread finishes, then the numAttempts should be 1 after stop().


was (Author: vincentpoon):
[~gjacoby] The check immediately after await() is checking the executor for # of active threads, not the numAttempts counter.
Runner.stop() is should wait for the thread to finish (after an interrupt).  If the thread finishes, then the numAttempts should be 1 after stop().

> When stopping IndexWriter, give tasks a chance to complete
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4990
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4990
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>         Attachments: PHOENIX-4990.v1.4.x-HBase-1.4.patch, PHOENIX-4990.v2.4.x-HBase-1.4.patch
>
>
> We've seen a race condition where an index write failure happens when a coprocessor is shutting down.  Since we don't give the index writer threads a chance to complete when shutdownNow() is called, there is a chance the coprocessor shuts down its HTables while an index writer thread is in PhoenixIndexFailurePolicy trying to disable an index, which ends up using a closed HTable and received RejectedExecutionException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)