You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (Jira)" <ji...@apache.org> on 2020/04/29 11:02:00 UTC
[jira] [Comment Edited] (HADOOP-17019) Declare ProtobufHelper a
public API
[ https://issues.apache.org/jira/browse/HADOOP-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095341#comment-17095341 ]
Steve Loughran edited comment on HADOOP-17019 at 4/29/20, 11:01 AM:
--------------------------------------------------------------------
we deliberately removed this precisely because it was an internal feature being exposed publicly and it as we shaded protobuf there were linkage problems. I would rather we don't expose the helper
Does something outside hadoop-* actually use this?
was (Author: stevel@apache.org):
we deliberately remnoved this precisely because it was an internal feature being exposed publicly and it as we shaded protobuf there were linkage problems. I would rather we don't expose the helper
Does something outside hadoop-* actually use this?
> Declare ProtobufHelper a public API
> -----------------------------------
>
> Key: HADOOP-17019
> URL: https://issues.apache.org/jira/browse/HADOOP-17019
> Project: Hadoop Common
> Issue Type: Task
> Affects Versions: 3.3.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
>
> HADOOP-16621 removed two public API methods:
> 1. o.a.h.security.token.Token(TokenProto tokenPB) --> replaced by o.a.h.security.ipc.ProtobufHelper.tokenFromProto()
> 2. o.a.h.security.token.Token.toTokenProto() --> replaced by o.a.h.security.ipc.ProtobufHelper.protoFromToken()
> Protobuf is declared private. Should we make it public now?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org