You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2019/12/22 10:14:15 UTC
[isis] branch master updated: ISIS-2177: log warning:
JDOStateManagerForIsis is currently not implemented
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new a0c2d03 ISIS-2177: log warning: JDOStateManagerForIsis is currently not implemented
a0c2d03 is described below
commit a0c2d03744b036512aeb8bc3bb9595ea34cccd4e
Author: Andi Huber <ah...@apache.org>
AuthorDate: Sun Dec 22 11:08:47 2019 +0100
ISIS-2177: log warning: JDOStateManagerForIsis is currently not
implemented
---
.../datanucleus/JDOStateManagerForIsis.java | 33 +++++++++++-----------
.../service/eventbus/EventBusServiceJdo.java | 4 ---
2 files changed, 17 insertions(+), 20 deletions(-)
diff --git a/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/JDOStateManagerForIsis.java b/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/JDOStateManagerForIsis.java
index 6495cb5..4c3ea66 100644
--- a/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/JDOStateManagerForIsis.java
+++ b/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/JDOStateManagerForIsis.java
@@ -19,7 +19,6 @@
package org.apache.isis.persistence.jdo.datanucleus5.datanucleus;
-import org.apache.isis.persistence.jdo.datanucleus5.datanucleus.service.eventbus.EventBusServiceJdo;
import org.datanucleus.ExecutionContext;
import org.datanucleus.cache.CachedPC;
import org.datanucleus.enhancement.Persistable;
@@ -29,11 +28,12 @@ import org.datanucleus.store.FieldValues;
import org.datanucleus.store.fieldmanager.FieldManager;
import org.apache.isis.applib.services.inject.ServiceInjector;
+import org.apache.isis.persistence.jdo.datanucleus5.datanucleus.service.eventbus.EventBusServiceJdo;
-/**
- * @deprecated This is bad practice: The lifecycle of persistent entities is usually decoupled from the lifecycle of a managed bean
- */
-@Deprecated
+import lombok.extern.log4j.Log4j2;
+
+//FIXME currently is a noop, resurrect or remove see https://stackoverflow.com/a/11648163/9269480
+@Log4j2
public class JDOStateManagerForIsis extends ReferentialStateManagerImpl {
private final ServiceInjector serviceInjector = null;
@@ -42,6 +42,7 @@ public class JDOStateManagerForIsis extends ReferentialStateManagerImpl {
super(ec, cmd);
// this.serviceInjector = (ServiceInjector) ec.getProperty("serviceInjector");
// requires(serviceInjector, "serviceInjector");
+ log.warn("not implemented: #injectServicesInto(...)");
}
public enum Hint {
@@ -63,62 +64,62 @@ public class JDOStateManagerForIsis extends ReferentialStateManagerImpl {
@Override
public void initialiseForHollow(Object id, FieldValues fv, Class pcClass) {
super.initialiseForHollow(id, fv, pcClass);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForHollowAppId(FieldValues fv, Class pcClass) {
super.initialiseForHollowAppId(fv, pcClass);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForHollowPreConstructed(Object id, Persistable pc) {
super.initialiseForHollowPreConstructed(id, pc);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForPersistentClean(Object id, Persistable pc) {
super.initialiseForPersistentClean(id, pc);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForEmbedded(Persistable pc, boolean copyPc) {
super.initialiseForEmbedded(pc, copyPc);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForPersistentNew(Persistable pc,
FieldValues preInsertChanges) {
super.initialiseForPersistentNew(pc, preInsertChanges);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForTransactionalTransient(Persistable pc) {
super.initialiseForTransactionalTransient(pc);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForDetached(Persistable pc, Object id, Object version) {
super.initialiseForDetached(pc, id, version);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForPNewToBeDeleted(Persistable pc) {
super.initialiseForPNewToBeDeleted(pc);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
public void initialiseForCachedPC(CachedPC<Persistable> cachedPC, Object id) {
super.initialiseForCachedPC(cachedPC, id);
- mapIntoIsis(myPC);
+ injectServicesInto(myPC);
}
@Override
@@ -220,7 +221,7 @@ public class JDOStateManagerForIsis extends ReferentialStateManagerImpl {
}
}
- protected void mapIntoIsis(Persistable pc) {
+ protected void injectServicesInto(Persistable pc) {
if(serviceInjector!=null) {
serviceInjector.injectServicesInto(pc);
}
diff --git a/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/service/eventbus/EventBusServiceJdo.java b/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/service/eventbus/EventBusServiceJdo.java
index 13f75de..057e748 100644
--- a/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/service/eventbus/EventBusServiceJdo.java
+++ b/core/persistence/jdo/datanucleus-5/src/main/java/org/apache/isis/persistence/jdo/datanucleus5/datanucleus/service/eventbus/EventBusServiceJdo.java
@@ -32,10 +32,6 @@ import org.apache.isis.persistence.jdo.datanucleus5.datanucleus.JDOStateManagerF
* {@link #post(Object) posted} from the setters of entities, automatically ignoring any calls to those setters that
* occur as a side-effect of the JDO load/detach lifecycle.
*
- * <p>
- * This implementation has no UI and there are no other implementations of the service API, and so it is annotated
- * with {@link org.apache.isis.applib.annotation.DomainService}. Because it is implemented in the core, this means
- * that it is automatically registered and available for use; no further configuration is required.
*/
@Deprecated //FIXME[2112] find a replacement for that feature!?
public class EventBusServiceJdo /*extends EventBusServiceDefault*/ {