You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/19 23:59:02 UTC
[GitHub] [arrow] wesm opened a new pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
wesm opened a new pull request #7802:
URL: https://github.com/apache/arrow/pull/7802
This reverts commit f86c4dbbc18d9b314338a868212ca80b05d2ed55.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-660732676
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661208643
Let's just verify the Spark tests pass after the reverting.
@ursabot crossbow submit test-conda-python-3.8-spark-master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-660753990
I don't think we should revert this fully. This also fixes a bug with as_datetime flag. Per mailing list discussion let me see if I can get round trip this evening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661210665
@kszucs is there a way to kick off Spark integration tests right now on master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661269532
@BryanCutler seems like the spark tests are passing with the current master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661209149
[AMD64 Conda Crossbow Submit (#120385)](https://ci.ursalabs.org/#builders/98/builds/646) builder failed.
Revision: 12840af97c9903a36877f7e494ed54fccbde1217
Clone Arrow: `update (failure)` step's stderr:
```
Cloning into '.'...
fatal: couldn't find remote ref refs/pull/7802/merge
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-660764203
I'll work on it tonight and try to get something out one way or another. Enjoy your time off
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661257796
@BryanCutler I already submitted them, the spark tests are still running https://github.com/ursa-labs/crossbow/branches/all?query=build-871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661209001
@ursabot crossbow submit test-conda-python-3.8-spark-master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661296416
great, thanks @kszucs !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs merged pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
kszucs merged pull request #7802:
URL: https://github.com/apache/arrow/pull/7802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7802: Revert "ARROW-9223: [Python] Propagate timezone information in pandas conversion"
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-660758993
OK. I won't be able to spend any time on it for several days at least
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org