[GitHub] [calcite] vlsi edited a comment on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

[GitBox <gi...@apache.org>]

vlsi edited a comment on pull request #2622:
URL: https://github.com/apache/calcite/pull/2622#issuecomment-996869051


   > We already depend on category X licenses for build/test (JMH is an example, I believe) 
   
   JMH is GPL with classpath exception, and that is explicitly allowed. There's no X in JMH.
   
   > Category X are prohibited in source releases and convenience binaries and I don't believe this change introduces any violation of that
   
   The spirit of ASF is that we produce code that **can** be modified by the consumers.
   Unfortunately, category X does limit the consumers (even if X appears in transitive dependencies), so it is much better to avoid X licenses for all the cases.
   
   Here's a recent case when ASF convinced **third-party** to remove a transitive LGPL dependency: https://issues.apache.org/jira/browse/LEGAL-572
   
   > As I understand it, the rest client we depend on for non-test code
   
   Code without tests is not really helpful 🤷 
   Do you consider "ES adapter" to be a test code for Calcite?
   I just thought "ES adapter" was a standalone helpful library.
   
   >X licenses in the ES test module, we should probably remove ES as a supported adapter
   
   I am not sure what are the options regarding forks, however, removing ES adapter or staying with the older version are reasonable options.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org