You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/19 04:54:00 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4541: Make `CommandService` daemon to avoid blocking target application shu…
kezhenxu94 opened a new pull request #4541: Make `CommandService` daemon to avoid blocking target application shu…
URL: https://github.com/apache/skywalking/pull/4541
…tting down gracefully
closes #4538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
URL: https://github.com/apache/skywalking/pull/4541#issuecomment-600997400
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=h1) Report
> Merging [#4541](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/28ac73bff3561084025c2bcb60ac37883eaabc6c?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
+ Coverage 25.53% 25.56% +0.02%
==========================================
Files 1244 1244
Lines 28951 28950 -1
Branches 3968 3968
==========================================
+ Hits 7392 7400 +8
+ Misses 20874 20866 -8
+ Partials 685 684 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4541/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `36.95% <57.14%> (+0.78%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4541/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `56.66% <0%> (+1.66%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4541/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=footer). Last update [28ac73b...aaddb03](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
URL: https://github.com/apache/skywalking/pull/4541#issuecomment-600988170
unfortunately, `CommandService` is the only one non-daemon thread, sorry about that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4541: Make `CommandService` daemon to avoid blocking target application shu…
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4541: Make `CommandService` daemon to avoid blocking target application shu…
URL: https://github.com/apache/skywalking/pull/4541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4541: Make `CommandService` daemon to avoid blocking target application shu…
URL: https://github.com/apache/skywalking/pull/4541#issuecomment-600997400
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=h1) Report
> Merging [#4541](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/28ac73bff3561084025c2bcb60ac37883eaabc6c?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
+ Coverage 25.53% 25.53% +<.01%
==========================================
Files 1244 1244
Lines 28951 28950 -1
Branches 3968 3968
==========================================
+ Hits 7392 7393 +1
+ Misses 20874 20873 -1
+ Partials 685 684 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/4541/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `36.95% <57.14%> (+0.78%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4541/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `56.66% <0%> (+1.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=footer). Last update [28ac73b...aaddb03](https://codecov.io/gh/apache/skywalking/pull/4541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services