[GitHub] [incubator-superset] ktmud commented on a change in pull request #11781: fix (dataset editor): allow Source tab readOnly mode

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11781:
URL: https://github.com/apache/incubator-superset/pull/11781#discussion_r533724187



##########
File path: superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -142,4 +147,65 @@ describe('DatasourceEditor', () => {
       wrapper.find(Field).find({ fieldKey: 'fetch_values_predicate' }).exists(),
     ).toBe(true);
   });
+
+  describe('enable edit Source tab', () => {
+    beforeAll(() => {
+      isFeatureEnabledMock = jest
+        .spyOn(featureFlags, 'isFeatureEnabled')
+        .mockImplementation(
+          feature => feature === 'ENABLE_DATASET_SOURCE_EDIT',

Review comment:
       I think this should be updated to `DISABLE_DATASET_SOURCE_EDIT` as well.
   
   Why did the test pass even when the feature flag is not correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org