You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/02/21 09:23:51 UTC
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/240
Remove redundant semicolons from enums
While enums allow ending the member list in a semicolon(;), it's
redundant. Some enums in the codebase use a semicolon in the end, and
some do not.
This patch standardizes the codebase's enum and cleans up the code by
removing these semicolons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang enum-semicolon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit c0d2d5b632211bb6ebc6fc0e93e133be1c3184ff
Author: Allon Mureinik <am...@redhat.com>
Date: 2017-02-21T09:18:54Z
Remove redundant semicolons from enums
While enums allow ending the member list in a semicolon(;), it's
redundant. Some enums in the codebase use a semicolon in the end, and
some do not.
This patch standardizes the codebase's enum and cleans up the code by
removing these semicolons.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by mureinik <gi...@git.apache.org>.
Github user mureinik commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102256442
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
- A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+ A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
- A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+ A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
I kept the style the code had. If we collectively decide that spaces would make the code better, I'd gladly add them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102192663
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
- A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+ A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
- A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+ A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
Should there be spaces between all values?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102318517
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
- A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+ A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
- A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+ A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
@PascalSchumacher created [PR #241](https://github.com/apache/commons-lang/pull/241) with minor changes of enum spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #240: Remove redundant semicolons from enums
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/240
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #240: Remove redundant semicolons from enums
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/240
[](https://coveralls.io/builds/10249437)
Coverage increased (+0.007%) to 94.536% when pulling **c0d2d5b632211bb6ebc6fc0e93e133be1c3184ff on mureinik:enum-semicolon** into **a64153a3710c5035988690f0acf57dd61b711cf4 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102281919
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
- A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+ A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
- A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+ A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
I guess there should, but let's keep this pull request focused one one thing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #240: Remove redundant semicolons from enums
Posted by Abrasha <gi...@git.apache.org>.
Github user Abrasha commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102314467
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass() {
A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
- A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+ A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
}
enum TooMany {
A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
- A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+ A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
}
--- End diff --
@PascalSchumacher I will see if we need to create separate PR with enum spacing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---