You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "davidradl (via GitHub)" <gi...@apache.org> on 2024/12/02 11:19:57 UTC

Re: [PR] [FLINK-36821] Update to Kafka 3.9.0 [flink-connector-kafka]

davidradl commented on code in PR #138:
URL: https://github.com/apache/flink-connector-kafka/pull/138#discussion_r1865676563


##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java:
##########
@@ -156,6 +157,11 @@ public List<PartitionInfo> partitionsFor(String topic) {
         return kafkaProducer.metrics();
     }
 
+    @Override

Review Comment:
   This change seems unrelated to the version change. If it is related please could you add a unit test. 
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org