You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/09 13:40:34 UTC
[GitHub] [flink] dawidwys opened a new pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
dawidwys opened a new pull request #14350:
URL: https://github.com/apache/flink/pull/14350
## What is the purpose of the change
The purpose is to remove the remaining occurences of `site.baseurl`.
## Brief change log
See the commit log for the commits.
## Verifying this change
Build the docs and click through them.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-741789271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10716",
"triggerID" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225b511666b2f1b5c411ab5ea917df43ffe338d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10716)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-741779073
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c225b511666b2f1b5c411ab5ea917df43ffe338d (Wed Dec 09 13:42:45 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-742392162
@sjwiesman I understand it's impossible to review every single line of the PR. I'd say if you are fine with the concepts/general changes that each commit represents and it builds, we could merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-741789271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10716",
"triggerID" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225b511666b2f1b5c411ab5ea917df43ffe338d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10716)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #14350:
URL: https://github.com/apache/flink/pull/14350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-742080380
I'm not entirely sure how to review this. It builds so +1 from me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14350:
URL: https://github.com/apache/flink/pull/14350#issuecomment-741789271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c225b511666b2f1b5c411ab5ea917df43ffe338d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225b511666b2f1b5c411ab5ea917df43ffe338d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #14350: [FLINK-20422] Remove site.baseurl from remaining .html templates
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #14350:
URL: https://github.com/apache/flink/pull/14350#discussion_r539667952
##########
File path: docs/_config.yml
##########
@@ -88,6 +88,7 @@ previous_docs:
exclude:
- "build_docs.sh"
- "check_links.sh"
+ - "spider.log"
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org